uwrap: Do an early return if log level doesn't match

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/src/uid_wrapper.c b/src/uid_wrapper.c
index a2ddd8b350c2379fb28375ae540938f7e39d3ebb..0e9be9655ad7c7d0f62bfaefd8d40de6b4870840 100644 (file)
--- a/src/uid_wrapper.c
+++ b/src/uid_wrapper.c
@@ -142,40 +142,42 @@ static void uwrap_log(enum uwrap_dbglvl_e dbglvl, const char *function, const ch
        va_list va;
        const char *d;
        unsigned int lvl = 0;
+       const char *prefix = "UWRAP";
 
        d = getenv("UID_WRAPPER_DEBUGLEVEL");
        if (d != NULL) {
                lvl = atoi(d);
        }
 
+       if (lvl < dbglvl) {
+               return;
+       }
+
        va_start(va, format);
        vsnprintf(buffer, sizeof(buffer), format, va);
        va_end(va);
 
-       if (lvl >= dbglvl) {
-               const char *prefix = "UWRAP";
-               switch (dbglvl) {
-                       case UWRAP_LOG_ERROR:
-                               prefix = "UWRAP_ERROR";
-                               break;
-                       case UWRAP_LOG_WARN:
-                               prefix = "UWRAP_WARN";
-                               break;
-                       case UWRAP_LOG_DEBUG:
-                               prefix = "UWRAP_DEBUG";
-                               break;
-                       case UWRAP_LOG_TRACE:
-                               prefix = "UWRAP_TRACE";
-                               break;
-               }
-
-               fprintf(stderr,
-                       "%s(%d) - %s: %s\n",
-                       prefix,
-                       (int)getpid(),
-                       function,
-                       buffer);
+       switch (dbglvl) {
+               case UWRAP_LOG_ERROR:
+                       prefix = "UWRAP_ERROR";
+                       break;
+               case UWRAP_LOG_WARN:
+                       prefix = "UWRAP_WARN";
+                       break;
+               case UWRAP_LOG_DEBUG:
+                       prefix = "UWRAP_DEBUG";
+                       break;
+               case UWRAP_LOG_TRACE:
+                       prefix = "UWRAP_TRACE";
+                       break;
        }
+
+       fprintf(stderr,
+               "%s(%d) - %s: %s\n",
+               prefix,
+               (int)getpid(),
+               function,
+               buffer);
 }
 
 /*****************