Revert "s4-dsdb Don't talloc_free() ares on failure, as LDB might free it later"
authorAndrew Bartlett <abartlet@samba.org>
Thu, 16 Dec 2010 21:43:33 +0000 (08:43 +1100)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 18 Dec 2010 01:19:59 +0000 (02:19 +0100)
This reverts commit 25163380239abbad28f1656c42e6fab1b92473d9 because
further analyis showed the real problem was introduced in 0941099a
(which changed the caller behaviour, but only for indexed searches).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Dec 18 02:19:59 CET 2010 on sn-devel-104

source4/dsdb/samdb/ldb_modules/descriptor.c

index b96e5b5ccd6dfd7314c5386f3c649dad7c967d3a..0ea91ba60071ee595dd3710c4c151baf7d1c7d5f 100644 (file)
@@ -545,6 +545,7 @@ static int descriptor_search_callback(struct ldb_request *req, struct ldb_reply
        }
 
 fail:
+       talloc_free(ares);
        return ldb_module_done(ac->req, NULL, NULL, ret);
 }