libgpo: Always check for ldap_server argument
authorGarming Sam <garming@catalyst.net.nz>
Tue, 21 Nov 2017 21:57:18 +0000 (10:57 +1300)
committerJeremy Allison <jra@samba.org>
Fri, 15 Dec 2017 20:43:18 +0000 (21:43 +0100)
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
libgpo/pygpo.c

index d7bb17382b25d7b56d76f762c91abff193455cb7..fba0e342c7f6068a04ed1ea3c6de18c4d04e230c 100644 (file)
@@ -192,9 +192,11 @@ static int py_ads_init(ADS *self, PyObject *args, PyObject *kwds)
        } else {
                realm = lp_realm();
                workgroup = lp_workgroup();
-               if (!ldap_server) return -1;
        }
 
+       if (ldap_server == NULL) {
+               return -1;
+       }
        if ( !(self->ads_ptr = ads_init(realm, workgroup, ldap_server)) )
                return -1;