s4:smb_server/smb/trans2.c - "talloc_move" isn't strictly necessary here

Since the "set" will be free'd afterwards "talloc_steal" is enough.

Reviewed-by: Tridge

diff --git a/source4/smb_server/smb/trans2.c b/source4/smb_server/smb/trans2.c
index 416d6f04f15e655dea6f7ef47c449244eb7d87c6..0a6c014e88a7a99e548aacc1a77cde9df5d03a78 100644 (file)
--- a/source4/smb_server/smb/trans2.c
+++ b/source4/smb_server/smb/trans2.c
@@ -1487,7 +1487,7 @@ static NTSTATUS dodc_or_sysvol_referral(TALLOC_CTX *ctx,
                        NT_STATUS_HAVE_NO_MEMORY_AND_FREE(dc_list, context);
 
                        for(j=0; j<set[i]->count; j++) {
-                               dc_list[num_dcs + j] = talloc_move(context, &set[i]->names[j]);
+                               dc_list[num_dcs + j] = talloc_steal(context, set[i]->names[j]);
                        }
                        num_dcs = num_dcs + set[i]->count;
                        TALLOC_FREE(set[i]);