git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8d9cbc7
)
s3: Fix Coverity ID 2195: NO_EFFECT
author
Volker Lendecke
<vl@samba.org>
Sun, 27 Mar 2011 19:31:44 +0000
(21:31 +0200)
committer
Volker Lendecke
<vl@samba.org>
Sun, 27 Mar 2011 20:22:12 +0000
(22:22 +0200)
level is unsigned
source3/rpc_server/spoolss/srv_spoolss_nt.c
patch
|
blob
|
history
diff --git
a/source3/rpc_server/spoolss/srv_spoolss_nt.c
b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index 030324c0853680746f9620295fc7e451dcd5dbbd..d95bd54aecafd86710aeac3259ffcb9294aae226 100644
(file)
--- a/
source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/
source3/rpc_server/spoolss/srv_spoolss_nt.c
@@
-1709,7
+1709,7
@@
WERROR _spoolss_OpenPrinterEx(struct pipes_struct *p,
return WERR_INVALID_PARAM;
}
- if (r->in.level
< 0 || r->in.level
> 3) {
+ if (r->in.level > 3) {
return WERR_INVALID_PARAM;
}
if ((r->in.level == 1 && !r->in.userlevel.level1) ||