git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dacb392
)
s3: Fix Coverity ID 2233, REVERSE_INULL
author
Volker Lendecke
<vl@samba.org>
Wed, 16 Mar 2011 20:48:50 +0000
(21:48 +0100)
committer
Volker Lendecke
<vl@samba.org>
Wed, 16 Mar 2011 21:07:24 +0000
(22:07 +0100)
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
source3/rpc_server/netlogon/srv_netlog_nt.c
patch
|
blob
|
history
diff --git
a/source3/rpc_server/netlogon/srv_netlog_nt.c
b/source3/rpc_server/netlogon/srv_netlog_nt.c
index bfa3bb25e8b4f177f4eb5931eecca2b92c71f062..e5d61242e33bb9f96b85b0eb53d4f1a1fbf0ca9d 100644
(file)
--- a/
source3/rpc_server/netlogon/srv_netlog_nt.c
+++ b/
source3/rpc_server/netlogon/srv_netlog_nt.c
@@
-490,7
+490,7
@@
NTSTATUS _netr_NetrEnumerateTrustedDomains(struct pipes_struct *p,
status = NT_STATUS_OK;
out:
- if (
h &&
is_valid_policy_hnd(&pol)) {
+ if (is_valid_policy_hnd(&pol)) {
dcerpc_lsa_Close(h, p->mem_ctx, &pol, &result);
}