s3: Fix Coverity ID 2147, FORWARD_NULL
authorVolker Lendecke <vl@samba.org>
Wed, 16 Mar 2011 20:24:58 +0000 (21:24 +0100)
committerVolker Lendecke <vl@samba.org>
Wed, 16 Mar 2011 21:07:24 +0000 (22:07 +0100)
How could this ever have worked???

source3/libsmb/conncache.c

index daac41e15a34e52405fe42bd512bf5327dbe7784..66353188d2b3fa8f36b8727cfbcd3d38cc841527 100644 (file)
@@ -99,7 +99,7 @@ static NTSTATUS negative_conn_cache_valuedecode(const char *value)
 {
        unsigned int v = NT_STATUS_V(NT_STATUS_INTERNAL_ERROR);
 
-       if (value != NULL) {
+       if (value == NULL) {
                return NT_STATUS_INTERNAL_ERROR;
        }
        if (sscanf(value, "%x", &v) != 1) {