s3: Fix Coverity ID 2236: REVERSE_INULL
authorVolker Lendecke <vl@samba.org>
Wed, 30 Mar 2011 04:57:05 +0000 (06:57 +0200)
committerVolker Lendecke <vl@samba.org>
Wed, 30 Mar 2011 07:58:33 +0000 (09:58 +0200)
We have already dereferenced "b", and the other calls in this loop can only
have worked with a valid handle

source3/smbd/lanman.c

index bf2987f9077349e4075bdd1fd0ce00598f0d8187..a04f06227479df89619cc22e2d920270b7d69b14 100644 (file)
@@ -1148,9 +1148,7 @@ static bool api_DosPrintQEnum(struct smbd_server_connection *sconn,
                subcntarr[i] = num_jobs;
                subcnt += subcntarr[i];
 
-               if (b && is_valid_policy_hnd(&handle)) {
-                       dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr);
-               }
+               dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr);
        }
 
        if (init_package(&desc,queuecnt,subcnt)) {