s4:pyldb - Fixed the return value in "py_ldb_msg_diff"
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Tue, 22 Sep 2009 12:10:52 +0000 (14:10 +0200)
committerMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Wed, 30 Sep 2009 14:01:17 +0000 (16:01 +0200)
The case distinction shouldn't be needed also when "diff" is NULL.
"PyLdbMessage_FromMessage" works with "NULL" arguments.

source4/lib/ldb/pyldb.c

index 1ba5109f2fde038464627f8a153bd3ed97d835d6..0fe4da988729e6986d58e4c7653c4b40bd8b04d1 100644 (file)
@@ -956,8 +956,6 @@ static PyObject *py_ldb_msg_diff(PyLdbObject *self, PyObject *args)
        }
 
        diff = ldb_msg_diff(PyLdb_AsLdbContext(self), PyLdbMessage_AsMessage(py_msg_old), PyLdbMessage_AsMessage(py_msg_new));
-       if (diff == NULL) 
-               return NULL;
 
        py_ret = PyLdbMessage_FromMessage(diff);