git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dd3d6a1
)
s3: Fix Coverity ID 2140, DEADCODE
author
Volker Lendecke
<vl@samba.org>
Wed, 16 Mar 2011 20:34:44 +0000
(21:34 +0100)
committer
Volker Lendecke
<vl@samba.org>
Wed, 16 Mar 2011 21:07:24 +0000
(22:07 +0100)
This routine was never executed after
f0dcc90f
because "netname" was always
NULL.
Jeremy, please check!
source3/smbd/lanman.c
patch
|
blob
|
history
diff --git
a/source3/smbd/lanman.c
b/source3/smbd/lanman.c
index 02ef033879d7dddd264ec686dd5e97daf603a251..75ec100d795d838d4ee7cf72b9c6d72c71c2731b 100644
(file)
--- a/
source3/smbd/lanman.c
+++ b/
source3/smbd/lanman.c
@@
-2005,7
+2005,7
@@
static bool api_RNetShareGetInfo(struct smbd_server_connection *sconn,
int uLevel = get_safe_SVAL(param,tpscnt,p,0,-1);
int snum;
- if (!str1 || !str2 || !netname || !p) {
+ if (!str1 || !str2 || !netname
_in
|| !p) {
return False;
}