libsmb: Simplify SMBC_add_cached_server()

ENOMEM is the only error condition we have

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/source3/libsmb/libsmb_cache.c b/source3/libsmb/libsmb_cache.c
index 6b8a1ab4af9f3c63033755f2cf4097b792eb93ef..b1a2d3d60cf12bd5236bfaed06805c61ce241bde 100644 (file)
--- a/source3/libsmb/libsmb_cache.c
+++ b/source3/libsmb/libsmb_cache.c
@@ -66,37 +66,34 @@ SMBC_add_cached_server(SMBCCTX * context,
 
        srvcache->server_name = SMB_STRDUP(server);
        if (!srvcache->server_name) {
-               errno = ENOMEM;
-               goto failed;
+               goto nomem;
        }
 
        srvcache->share_name = SMB_STRDUP(share);
        if (!srvcache->share_name) {
-               errno = ENOMEM;
-               goto failed;
+               goto nomem;
        }
 
        srvcache->workgroup = SMB_STRDUP(workgroup);
        if (!srvcache->workgroup) {
-               errno = ENOMEM;
-               goto failed;
+               goto nomem;
        }
 
        srvcache->username = SMB_STRDUP(username);
        if (!srvcache->username) {
-               errno = ENOMEM;
-               goto failed;
+               goto nomem;
        }
 
        DLIST_ADD(context->internal->server_cache, srvcache);
        return 0;
 
-failed:
+nomem:
        SAFE_FREE(srvcache->server_name);
        SAFE_FREE(srvcache->share_name);
        SAFE_FREE(srvcache->workgroup);
        SAFE_FREE(srvcache->username);
        SAFE_FREE(srvcache);
+       errno = ENOMEM;
 
        return 1;
 }