s4:dns_server: less noisy, more informative debug messages
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 10 Apr 2024 23:52:14 +0000 (11:52 +1200)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 12 Apr 2024 15:18:05 +0000 (15:18 +0000)
This shouldn't have been DBG_ERR, and it might as well say something
about the tombstone.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15630

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Apr 12 15:18:05 UTC 2024 on atb-devel-224

source4/dns_server/dnsserver_common.c

index d82e309f982a3aa87f0598de9313051df9d62d6e..1cbd7d94593c0850fb4f3f30df2c4bdfb83dc7ed 100644 (file)
@@ -1034,10 +1034,11 @@ WERROR dns_common_replace(struct ldb_context *samdb,
                         * record.
                         */
                        if (records[i].data.EntombedTime != 0) {
-                               if (rec_count != 1) {
-                                       DBG_ERR("tombstone record has %u neighbour "
-                                               "records.\n",
-                                               rec_count - 1);
+                               if (rec_count != 1 && DEBUGLVL(DBGLVL_NOTICE)) {
+                                       DBG_NOTICE("tombstone record [%u] has "
+                                                  "%u neighbour records.\n",
+                                                  i, rec_count - 1);
+                                       NDR_PRINT_DEBUG(dnsp_DnssrvRpcRecord, &records[i]);
                                }
                                was_tombstoned = true;
                        }