s4/auth/kerberos: clang: Fix 'value stored to 'ret' is never read '

Fixes:

source4/auth/kerberos/kerberos_pac.c:116:2: warning: Value stored to 'ret' is never read <--[clang]
        ret = smb_krb5_make_pac_checksum(mem_ctx,
        ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/source4/auth/kerberos/kerberos_pac.c b/source4/auth/kerberos/kerberos_pac.c
index e45a846cd8890135f4000be6b1a530910b3b6e7d..54ef4d61b025b648244739f1d32989de8dd3de8e 100644 (file)
--- a/source4/auth/kerberos/kerberos_pac.c
+++ b/source4/auth/kerberos/kerberos_pac.c
@@ -120,6 +120,13 @@
                                         &srv_checksum->type,
                                         &srv_checksum->signature);
 
+       if (ret) {
+               DBG_WARNING("making krbtgt PAC srv_checksum failed: %s\n",
+                           smb_get_krb5_error_message(context, ret, mem_ctx));
+               talloc_free(pac_data);
+               return ret;
+       }
+
        /* Then sign Server checksum */
        ret = smb_krb5_make_pac_checksum(mem_ctx,
                                         &srv_checksum->signature,
@@ -128,8 +135,8 @@
                                         &kdc_checksum->type,
                                         &kdc_checksum->signature);
        if (ret) {
-               DEBUG(2, ("making krbtgt PAC checksum failed: %s\n",
-                         smb_get_krb5_error_message(context, ret, mem_ctx)));
+               DBG_WARNING("making krbtgt PAC kdc_checksum failed: %s\n",
+                           smb_get_krb5_error_message(context, ret, mem_ctx));
                talloc_free(pac_data);
                return ret;
        }