selftest: Report better error message if environment is unknown
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 16 May 2023 00:04:49 +0000 (12:04 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 24 May 2023 00:50:31 +0000 (00:50 +0000)
Now we get the error “environment [...] is unknown” rather than “samba
can't start up known environment”.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
selftest/target/Samba.pm

index 29a612aab8b2356de258ac0060e05d5113569cf9..334665a6ff2c0b2ac070c9003c9c2cb1542b5a58 100644 (file)
@@ -129,7 +129,7 @@ sub setup_env($$$)
        }
        if ($env eq "UNKNOWN") {
                warn("unknown environment '$envname'");
-               return undef;
+               return $env;
        }
 
        $target->{vars}->{$envname} = $env;