heimdal_build: Rework Heimdal warning handling

If we have all the right -Wno-error flags then we can enable warnings
more generally, otherwise just set -Wno-strict-overflow (if available)

Adapted from patches by Stefan Metzmacher <metze@samba.org> in his
branch to update Heimdal.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source4/heimdal_build/wscript_build b/source4/heimdal_build/wscript_build
index 3d1464b12c4ba78aae105f759a2a5d6cb6b2b12b..b6403f33f35dac4f18410126aa649ba122e95944 100644 (file)
--- a/source4/heimdal_build/wscript_build
+++ b/source4/heimdal_build/wscript_build
@@ -212,7 +212,7 @@ def HEIMDAL_GENERATOR(name, rule, source='', target='',
         name=name)
 
 
-def HEIMDAL_LIBRARY(libname, source, deps, vnum, version_script, includes=''):
+def HEIMDAL_LIBRARY(libname, source, deps, vnum, version_script, includes='', cflags=[]):
     '''define a Heimdal library'''
 
     obj_target = libname + '.objlist'
@@ -224,6 +224,7 @@ def HEIMDAL_LIBRARY(libname, source, deps, vnum, version_script, includes=''):
                         source         = source,
                         deps           = deps,
                         includes       = includes,
+                        cflags         = cflags,
                         group          = 'main')
 
     if not SET_TARGET_TYPE(bld, libname, "LIBRARY"):
@@ -262,6 +263,20 @@ def HEIMDAL_LIBRARY(libname, source, deps, vnum, version_script, includes=''):
         version_script  = heimdal_path(version_script, absolute=True),
         )
 
+def HEIMDAL_CFLAGS(use_hostcc=False, extra_cflags=[]):
+    cflags_unpicky=[]
+
+    if not bld.env.enable_heimdal_warnings:
+        cflags_unpicky += bld.env.HEIMDAL_UNPICKY_WNO_STRICT_OVERFLOW_CFLAGS
+        # old compilers on centos7 or ubuntu1604 need this
+
+    allow_warnings = bld.env.allow_heimdal_warnings
+    cflags_picky = bld.env.HEIMDAL_NO_ERROR_CFLAGS
+    extra_cflags=TO_LIST(extra_cflags)
+
+    cflags = ''
+    cflags_end = cflags_picky + cflags_unpicky + extra_cflags
+    return (cflags, cflags_end, allow_warnings)
 
 def HEIMDAL_SUBSYSTEM(modname, source,
                     deps='',
@@ -272,37 +287,20 @@ def HEIMDAL_SUBSYSTEM(modname, source,
                     use_global_deps=True):
     '''define a Heimdal subsystem'''
 
-    if not SET_TARGET_TYPE(bld, modname, 'SUBSYSTEM'):
-        return
-
+    cflags, cflags_end, allow_warnings = HEIMDAL_CFLAGS(use_hostcc=use_hostcc,
+                                                        extra_cflags=cflags)
     source = heimdal_paths(source)
 
-    bld.set_group(group)
-
-    # If we found the -Wno-error options we need then build without
-    # allowing warnings, otherwise permit them
-    if bld.env.enable_heimdal_warnings:
-        samba_cflags = CURRENT_CFLAGS(bld, modname, cflags) + \
-                       bld.env.HEIMDAL_PICKY_CFLAGS
-    else:
-        samba_cflags = CURRENT_CFLAGS(bld, modname, cflags,
-                                      allow_warnings=True) + \
-                       bld.env.HEIMDAL_UNPICKY_WNO_STRICT_OVERFLOW_CFLAGS
-
-    return bld(
-        features       = 'c',
-        source         = source,
-        target         = modname,
-        samba_cflags   = samba_cflags,
-        depends_on     = '',
-        samba_deps     = TO_LIST(deps),
-        samba_includes = includes,
-        local_include  = True,
-        local_include_first  = True,
-        samba_use_hostcc = use_hostcc,
-        samba_use_global_deps = use_global_deps
-        )
-
+    bld.SAMBA_SUBSYSTEM(modname,
+                        source         = source,
+                        deps           = deps,
+                        includes       = includes,
+                        cflags         = cflags,
+                        cflags_end     = cflags_end,
+                        allow_warnings = allow_warnings,
+                        group          = group,
+                        use_hostcc     = use_hostcc,
+                        use_global_deps= use_global_deps)
 
 def HEIMDAL_BINARY(binname, source,
                  deps='',
@@ -316,6 +314,7 @@ def HEIMDAL_BINARY(binname, source,
                  install_path=None):
     '''define a Samba binary'''
 
+    cflags, cflags_end, allow_warnings = HEIMDAL_CFLAGS(use_hostcc=use_hostcc)
     source = heimdal_paths(source)
 
     obj_target = binname + '.heimdal.objlist'
@@ -334,6 +333,8 @@ def HEIMDAL_BINARY(binname, source,
                      deps           = obj_target,
                      includes       = includes,
                      cflags         = cflags,
+                     cflags_end     = cflags_end,
+                     allow_warnings = allow_warnings,
                      group          = group,
                      use_hostcc     = use_hostcc,
                      use_global_deps= use_global_deps,

diff --git a/source4/heimdal_build/wscript_configure b/source4/heimdal_build/wscript_configure
index 049ea27b5d50a49e6a2b80a0d8a791d741a8a79e..14fad4dff96c49fa1c61e92d82bfc3fffdb794df 100644 (file)
--- a/source4/heimdal_build/wscript_configure
+++ b/source4/heimdal_build/wscript_configure
@@ -76,18 +76,22 @@ heimdal_no_error_flags = ['-Wno-error=discarded-qualifiers',
                           '-Wno-error=unused-variable',
                           '-Wno-error=unused-result']
 for flag in heimdal_no_error_flags:
-    conf.ADD_NAMED_CFLAGS('HEIMDAL_PICKY_CFLAGS',
+    conf.ADD_NAMED_CFLAGS('HEIMDAL_NO_ERROR_CFLAGS',
                           flag,
                           testflags=True)
 
-if len(bld.env.HEIMDAL_PICKY_CFLAGS) == len(heimdal_no_error_flags):
-    conf.env.enable_heimdal_warnings = True
+if len(bld.env.HEIMDAL_NO_ERROR_CFLAGS) == len(heimdal_no_error_flags):
+    Logs.info("Most warnings in Heimdal code will "
+              "error due to -Werror (good)")
 else:
+    conf.env.allow_heimdal_warnings = True
     # Needed on CentOS 7 and Ubuntu 16.04 only for Bison generated
     # files when we are not doing strict warnings -> errors
     conf.ADD_NAMED_CFLAGS('HEIMDAL_UNPICKY_WNO_STRICT_OVERFLOW_CFLAGS',
                           '-Wno-strict-overflow',
                           testflags=True)
+    Logs.info("Allowing warnings in Heimdal code as this compiler does "
+              "not support enough -Wno-error flags (bad)")
 
 conf.DEFINE('SAMBA4_USES_HEIMDAL', 1)