ldb-samba:ldif_handlers: dn_link_comparison semi-sorts invalid DNs

these tend to go to the end of the sorted array.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/lib/ldb-samba/ldif_handlers.c b/lib/ldb-samba/ldif_handlers.c
index 83199019ed3c1c112726c9acade7e7e8b87fc8a1..1229d7466b6067f26392b5b06153b45111edc700 100644 (file)
--- a/lib/ldb-samba/ldif_handlers.c
+++ b/lib/ldb-samba/ldif_handlers.c
@@ -1174,7 +1174,9 @@ static int samba_ldb_dn_link_comparison(struct ldb_context *ldb, void *mem_ctx,
        }
 
        dn1 = ldb_dn_from_ldb_val(mem_ctx, ldb, v1);
-       if ( ! ldb_dn_validate(dn1)) return -1;
+       if ( ! ldb_dn_validate(dn1)) {
+               return 1;
+       }
 
        dn2 = ldb_dn_from_ldb_val(mem_ctx, ldb, v2);
        if ( ! ldb_dn_validate(dn2)) {