git.samba.org
/
kai
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ff32391
)
s3-rpcclient: Check return value of add_string_to_array().
author
Andreas Schneider
<asn@samba.org>
Mon, 10 Dec 2012 16:41:46 +0000
(17:41 +0100)
committer
Günther Deschner
<gd@samba.org>
Wed, 12 Dec 2012 08:42:32 +0000
(09:42 +0100)
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
source3/rpcclient/cmd_spoolss.c
patch
|
blob
|
history
diff --git
a/source3/rpcclient/cmd_spoolss.c
b/source3/rpcclient/cmd_spoolss.c
index c3ac21172e3abedd4ee613b63d5b60fb02b5ce2b..52631849e09f6e55fdb98c0629871ca6928a08b8 100644
(file)
--- a/
source3/rpcclient/cmd_spoolss.c
+++ b/
source3/rpcclient/cmd_spoolss.c
@@
-1672,7
+1672,11
@@
static bool init_drv_info_3_members(TALLOC_CTX *mem_ctx, struct spoolss_AddDrive
}
while (str != NULL) {
- add_string_to_array(deps, str, &file_array, &count);
+ bool ok;
+ ok = add_string_to_array(deps, str, &file_array, &count);
+ if (!ok) {
+ return false;
+ }
str = strtok_r(NULL, ",", &saveptr);
}