Free protect_ids in secret_store_domain_sid() as the caller of fetch_secrets() must...
authorMichele Baldessari <michele@acksyn.org>
Wed, 5 Sep 2012 17:56:06 +0000 (10:56 -0700)
committerJeremy Allison <jra@samba.org>
Wed, 5 Sep 2012 20:20:45 +0000 (22:20 +0200)
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep  5 22:20:45 CEST 2012 on sn-devel-104

source3/passdb/machine_account_secrets.c

index 300455a2e56306a2a86e6d470c39a7777a042d9b..70d7106176f4950a0dfa2982152745f5199d3219 100644 (file)
@@ -101,9 +101,11 @@ bool secrets_store_domain_sid(const char *domain, const struct dom_sid  *sid)
                if (strncmp(protect_ids, "TRUE", 4)) {
                        DEBUG(0, ("Refusing to store a Domain SID, "
                                  "it has been marked as protected!\n"));
+                       SAFE_FREE(protect_ids);
                        return false;
                }
        }
+       SAFE_FREE(protect_ids);
 #endif
 
        ret = secrets_store(domain_sid_keystr(domain), sid, sizeof(struct dom_sid ));