torture:smb2: use assert, not warning in error case in durable-v2-open.reopen1a
authorMichael Adam <obnox@samba.org>
Tue, 15 Mar 2016 08:39:43 +0000 (09:39 +0100)
committerJeremy Allison <jra@samba.org>
Mon, 21 Mar 2016 23:23:22 +0000 (00:23 +0100)
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/torture/smb2/durable_v2_open.c

index f3ec344efcc66d77236596b35993bec57996f5d3..a80506acbdcc611cc75a640412909d568b9440b0 100644 (file)
@@ -629,13 +629,9 @@ bool test_durable_v2_open_reopen1a(struct torture_context *tctx,
 
        previous_session_id = smb2cli_session_current_id(tree->session->smbXcli);
 
-       if (!torture_smb2_connection_ext(tctx, previous_session_id,
-                                        &options, &tree2))
-       {
-               torture_warning(tctx, "couldn't reconnect, bailing\n");
-               ret = false;
-               goto done;
-       }
+       ret = torture_smb2_connection_ext(tctx, previous_session_id,
+                                         &options, &tree2);
+       torture_assert_goto(tctx, ret, ret, done, "couldn't reconnect");
 
        /*
         * check that this has deleted the old session