ntquotas - skip entry if the quota is zero
authorUri Simchoni <uri@samba.org>
Wed, 30 Mar 2016 10:59:39 +0000 (13:59 +0300)
committerJeremy Allison <jra@samba.org>
Thu, 31 Mar 2016 18:30:10 +0000 (20:30 +0200)
When listing user quotas, do not list the user
if the driver returned success with zero quota -
this signals that no quota is assigned for that
user.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/ntquotas.c

index b9fd2f13802e735da5dacfd1f82a4382481aaf86..9b2e39a72bf8e1e0d702f693202fcd5268388fb9 100644 (file)
@@ -189,6 +189,11 @@ int vfs_get_user_ntquota_list(files_struct *fsp, SMB_NTQUOTA_LIST **qt_list)
                status =
                    vfs_get_ntquota(fsp, SMB_USER_QUOTA_TYPE, &sid, &tmp_qt);
                if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(5, ("failed getting quota for uid[%ld] - %s\n",
+                                 (long)usr->pw_uid, nt_errstr(status)));
+                       continue;
+               }
+               if (tmp_qt.softlim == 0 && tmp_qt.hardlim == 0) {
                        DEBUG(5,("no quota entry for sid[%s] path[%s]\n",
                                 sid_string_dbg(&sid),
                                 fsp->conn->connectpath));