s3-rpc_client: Fix updating netlogon credentials.

Signed-off-by: Günther Deschner <gd@samba.org>

diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
index 38f0d7aa1ac2918c6cf447a399142f0a961590d6..8b9e513b000ce0ff6c068a652b79cb3a1e5067b4 100644 (file)
--- a/source3/rpc_client/cli_pipe.c
+++ b/source3/rpc_client/cli_pipe.c
@@ -1800,9 +1800,6 @@ static void rpc_pipe_bind_step_two_done(struct tevent_req *subreq)
        struct rpc_pipe_bind_state *state =
                tevent_req_data(req,
                                struct rpc_pipe_bind_state);
-       struct schannel_state *schannel_auth =
-               talloc_get_type_abort(state->cli->auth->auth_ctx,
-                                     struct schannel_state);
        NTSTATUS status;
 
        status = dcerpc_netr_LogonGetCapabilities_r_recv(subreq, talloc_tos());
@@ -1860,8 +1857,8 @@ static void rpc_pipe_bind_step_two_done(struct tevent_req *subreq)
                return;
        }
 
-       TALLOC_FREE(schannel_auth->creds);
-       schannel_auth->creds = talloc_steal(state->cli, state->creds);
+       TALLOC_FREE(state->cli->dc);
+       state->cli->dc = talloc_steal(state->cli, state->creds);
 
        if (!NT_STATUS_IS_OK(state->r.out.result)) {
                DEBUG(0, ("dcerpc_netr_LogonGetCapabilities_r_recv failed with %s\n",
@@ -3016,10 +3013,12 @@ NTSTATUS cli_rpc_pipe_open_schannel_with_key(struct cli_state *cli,
         * The credentials on a new netlogon pipe are the ones we are passed
         * in - copy them over
         */
-       result->dc = netlogon_creds_copy(result, *pdc);
        if (result->dc == NULL) {
-               TALLOC_FREE(result);
-               return NT_STATUS_NO_MEMORY;
+               result->dc = netlogon_creds_copy(result, *pdc);
+               if (result->dc == NULL) {
+                       TALLOC_FREE(result);
+                       return NT_STATUS_NO_MEMORY;
+               }
        }
 
        DEBUG(10,("cli_rpc_pipe_open_schannel_with_key: opened pipe %s to machine %s "