git.samba.org
/
metze
/
samba
/
wip.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
742296d
)
nmbd: Fix request data data processing.
author
Andreas Schneider
<asn@samba.org>
Mon, 18 Feb 2013 16:21:31 +0000
(17:21 +0100)
committer
Alexander Bokovoy
<ab@samba.org>
Fri, 22 Feb 2013 15:36:12 +0000
(16:36 +0100)
answers->rdata is an array and will never be NULL.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
source3/nmbd/nmbd_browsesync.c
patch
|
blob
|
history
diff --git
a/source3/nmbd/nmbd_browsesync.c
b/source3/nmbd/nmbd_browsesync.c
index 8bc28ad301bb93665a3ef61c179d4354377caa34..30d2891a863619e599ce68a0403b312d08545767 100644
(file)
--- a/
source3/nmbd/nmbd_browsesync.c
+++ b/
source3/nmbd/nmbd_browsesync.c
@@
-194,7
+194,7
@@
static void domain_master_node_status_success(struct subnet_record *subrec,
/* Go through the list of names found at answers->rdata and look for
the first SERVER<0x20> name. */
- if
(answers->rdata != NULL
) {
+ if
(answers->rdlength > 0
) {
char *p = answers->rdata;
int numnames = CVAL(p, 0);
@@
-416,7
+416,7
@@
static void get_domain_master_name_node_status_success(struct subnet_record *sub
* the first WORKGROUP<0x1b> name.
*/
- if
(answers->rdata != NULL
) {
+ if
(answers->rdlength > 0
) {
char *p = answers->rdata;
int numnames = CVAL(p, 0);