net: Fix CID 1414752 Resource leak
authorVolker Lendecke <vl@samba.org>
Fri, 30 Mar 2018 14:15:30 +0000 (09:15 -0500)
committerJeremy Allison <jra@samba.org>
Tue, 3 Apr 2018 22:44:23 +0000 (00:44 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/utils/net_cache.c

index 8f9f69f8659a066b66d2bd328c14d5e3af33f756..98c5803c42856593ebf1bb416fe55d3881a1ac40 100644 (file)
@@ -456,6 +456,7 @@ static int net_cache_samlogon_show(struct net_context *c,
                                      &num_user_sids,
                                      true);
        if (!NT_STATUS_IS_OK(status)) {
+               TALLOC_FREE(user_sids);
                d_printf("sid_array_from_info3 failed for %s\n", sid_str);
                return -1;
        }
@@ -465,6 +466,8 @@ static int net_cache_samlogon_show(struct net_context *c,
                         i, sid_string_dbg(&user_sids[i]));
        }
 
+       TALLOC_FREE(user_sids);
+
        return 0;
 }