s4/messaging: do not deref NULL state (CID 1437973)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/lib/messaging/messaging.c b/source4/lib/messaging/messaging.c
index 6cf58539a750dec927fadbecced71a9720e5d93a..1f27cf74e17a205714fcbf16821876f7f14db148 100644 (file)
--- a/source4/lib/messaging/messaging.c
+++ b/source4/lib/messaging/messaging.c
@@ -578,6 +578,10 @@ static void imessaging_post_handler(struct tevent_context *ev,
        struct imessaging_post_state *state = talloc_get_type_abort(
                private_data, struct imessaging_post_state);
 
+       if (state == NULL) {
+               return;
+       }
+
        /*
         * In usecases like using messaging_client_init() with irpc processing
         * we may free the imessaging_context during the messaging handler.
@@ -594,10 +598,6 @@ static void imessaging_post_handler(struct tevent_context *ev,
        imessaging_dgm_recv(ev, state->buf, state->buf_len, NULL, 0,
                            state->msg_ctx);
 
-       if (state == NULL) {
-               return;
-       }
-
        state->busy_ref = NULL;
        TALLOC_FREE(state);
 }