LDB:ldb_tdb.c - also special entries should be checked for duplicate values
authorMatthias Dieter Wallnöfer <mdw@samba.org>
Tue, 4 Sep 2012 17:02:02 +0000 (19:02 +0200)
committerStefan Metzmacher <metze@samba.org>
Wed, 25 Sep 2013 08:46:26 +0000 (10:46 +0200)
The exclusion can be removed since the special attribute (@...) handling has
been fixed.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=8929

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb/ldb_tdb/ldb_tdb.c

index 3c24c15f0483d0d178ab2cc38a100651827c8b31..a8c6e97ec129590a0cf1349bcae5275fbef30a6c 100644 (file)
@@ -367,12 +367,6 @@ static int ltdb_add_internal(struct ldb_module *module,
                        return LDB_ERR_CONSTRAINT_VIOLATION;
                }
 
-               /* Do not check "@ATTRIBUTES" for duplicated values */
-               if (ldb_dn_is_special(msg->dn) &&
-                   ldb_dn_check_special(msg->dn, LTDB_ATTRIBUTES)) {
-                       continue;
-               }
-
                /* TODO: This is O(n^2) - replace with more efficient check */
                for (j=0; j<el->num_values; j++) {
                        if (ldb_msg_find_val(el, &el->values[j]) != &el->values[j]) {