pygpo: Fix CID 1422263 Resource leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
index ac6e3237a829e01876a997d7492c5d43d22cce78..db33602112558d6c6677bc2bb1d2bba4620e01ed 100644 (file)
--- a/libgpo/pygpo.c
+++ b/libgpo/pygpo.c
@@ -264,12 +264,12 @@ static PyObject* py_ads_connect(ADS *self)
                        Py_RETURN_FALSE;
                }
                self->ads_ptr->auth.password = smb_xstrdup(passwd);
+               SAFE_FREE(passwd);
                self->ads_ptr->auth.realm =
                        smb_xstrdup(self->ads_ptr->server.realm);
                if (!strupper_m(self->ads_ptr->auth.realm)) {
                        PyErr_SetString(PyExc_SystemError, "Failed to strdup");
                        TALLOC_FREE(frame);
-                       SAFE_FREE(passwd);
                        Py_RETURN_FALSE;
                }
 
@@ -278,7 +278,6 @@ static PyObject* py_ads_connect(ADS *self)
                        PyErr_SetString(PyExc_SystemError,
                                        "ads_connect() failed");
                        TALLOC_FREE(frame);
-                       SAFE_FREE(passwd);
                        Py_RETURN_FALSE;
                }
        }