vfs_fake_perms: Fix bug 9775, segfault for "artificial" conn_structs
authorVolker Lendecke <vl@samba.org>
Tue, 9 Apr 2013 19:18:34 +0000 (21:18 +0200)
committerKarolin Seeger <kseeger@samba.org>
Thu, 11 Apr 2013 07:38:38 +0000 (09:38 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
The last 3 patches address bug #9775, segfault for "artificial" conn_structs.

source3/modules/vfs_fake_perms.c

index f8d89019beafccbb4e80fe53afb8f0cb79a89cce..8eb6e3c7792ab7d277b70f796f00984f8aa60abd 100644 (file)
@@ -44,8 +44,21 @@ static int fake_perms_stat(vfs_handle_struct *handle,
        } else {
                smb_fname->st.st_ex_mode = S_IRWXU;
        }
-       smb_fname->st.st_ex_uid = handle->conn->session_info->unix_token->uid;
-       smb_fname->st.st_ex_gid = handle->conn->session_info->unix_token->gid;
+
+       if (handle->conn->session_info != NULL) {
+               struct security_unix_token *utok;
+
+               utok = handle->conn->session_info->unix_token;
+               smb_fname->st.st_ex_uid = utok->uid;
+               smb_fname->st.st_ex_gid = utok->gid;
+       } else {
+               /*
+                * We have an artificial connection for dfs for example. It
+                * sucks, but the current uid/gid is the best we have.
+                */
+               smb_fname->st.st_ex_uid = geteuid();
+               smb_fname->st.st_ex_gid = getegid();
+       }
 
        return ret;
 }
@@ -64,8 +77,20 @@ static int fake_perms_fstat(vfs_handle_struct *handle, files_struct *fsp, SMB_ST
        } else {
                sbuf->st_ex_mode = S_IRWXU;
        }
-       sbuf->st_ex_uid = handle->conn->session_info->unix_token->uid;
-       sbuf->st_ex_gid = handle->conn->session_info->unix_token->gid;
+       if (handle->conn->session_info != NULL) {
+               struct security_unix_token *utok;
+
+               utok = handle->conn->session_info->unix_token;
+               sbuf->st_ex_uid = utok->uid;
+               sbuf->st_ex_gid = utok->gid;
+       } else {
+               /*
+                * We have an artificial connection for dfs for example. It
+                * sucks, but the current uid/gid is the best we have.
+                */
+               sbuf->st_ex_uid = geteuid();
+               sbuf->st_ex_gid = getegid();
+       }
 
        return ret;
 }