winbind: "internal" children never have a domain set
authorVolker Lendecke <vl@samba.org>
Mon, 26 Feb 2018 12:14:21 +0000 (13:14 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 1 Mar 2018 08:53:45 +0000 (09:53 +0100)
Look at setup_domain_child(): There we always set child->domain. The only other
two children are the idmap and locator children, which don't have a domain set.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/winbindd/winbindd_dual.c

index 3c949d943f9e2f3f6203054fd4006df1908b2da5..a7d1ceedcb5cf3d407c5855631aa03758cc311ca 100644 (file)
@@ -897,9 +897,8 @@ void winbind_msg_offline(struct messaging_context *msg_ctx,
        }
 
        for (child = winbindd_children; child != NULL; child = child->next) {
-               /* Don't send message to internal children.  We've already
-                  done so above. */
-               if (!child->domain || winbindd_internal_child(child)) {
+               /* Only set domain children offline */
+               if (child->domain == NULL) {
                        continue;
                }
 
@@ -972,8 +971,8 @@ void winbind_msg_online(struct messaging_context *msg_ctx,
        }
 
        for (child = winbindd_children; child != NULL; child = child->next) {
-               /* Don't send message to internal childs. */
-               if (!child->domain || winbindd_internal_child(child)) {
+               /* Only set domain children online */
+               if (child->domain == NULL) {
                        continue;
                }