winbindd: simplify an if condition in winbindd_dual_pam_auth
authorRalph Boehme <slow@samba.org>
Tue, 9 Jan 2018 17:57:53 +0000 (18:57 +0100)
committerRalph Boehme <slow@samba.org>
Sat, 13 Jan 2018 07:24:09 +0000 (08:24 +0100)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/winbindd/winbindd_pam.c

index 56c2d3a7455aec5a653f1ff8f111a6db285750e2..3ae4174185da5826a42667553aeff8c57dc5afda 100644 (file)
@@ -1949,13 +1949,11 @@ cached_logon:
 
                result = winbindd_dual_pam_auth_cached(domain, state, &info3);
 
-               if (NT_STATUS_IS_OK(result)) {
-                       DEBUG(10,("winbindd_dual_pam_auth_cached succeeded\n"));
-                       goto process_result;
-               } else {
+               if (!NT_STATUS_IS_OK(result)) {
                        DEBUG(10,("winbindd_dual_pam_auth_cached failed: %s\n", nt_errstr(result)));
                        goto done;
                }
+               DEBUG(10,("winbindd_dual_pam_auth_cached succeeded\n"));
        }
 
 process_result: