tevent: Save 140 bytes of .text in tevent_req_create

This is one of or hottest code paths, I think every bit counts here.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/lib/tevent/tevent_req.c b/lib/tevent/tevent_req.c
index 2d9cc6db5743bf0f93b1df6b8fc9d6b234b6c0d9..fe613cc834ca152a93ff958cd2419ae67a56fd5b 100644 (file)
--- a/lib/tevent/tevent_req.c
+++ b/lib/tevent/tevent_req.c
@@ -77,16 +77,14 @@ struct tevent_req *_tevent_req_create(TALLOC_CTX *mem_ctx,
                .internal.trigger               = tevent_create_immediate(req)
        };
 
-       if (!req->internal.trigger) {
-               talloc_free(req);
-               return NULL;
-       }
-
        data = talloc_zero_size(req, data_size);
-       if (data == NULL) {
-               talloc_free(req);
-               return NULL;
-       }
+
+       /*
+        * No need to check for req->internal.trigger!=NULL or
+        * data!=NULL, this can't fail: talloc_pooled_object has
+        * already allocated sufficient memory.
+        */
+
        talloc_set_name_const(data, type);
 
        req->data = data;