selftest: s3: add a test for spnego downgrade from krb5 to ntlm
authorIsaac Boukris <iboukris@gmail.com>
Mon, 7 Oct 2019 20:51:19 +0000 (23:51 +0300)
committerAndreas Schneider <asn@cryptomilk.org>
Sat, 12 Oct 2019 14:33:32 +0000 (14:33 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
selftest/knownfail.d/spnego_downgrade [new file with mode: 0644]
selftest/target/Samba3.pm
source3/script/tests/test_smbd_no_krb5.sh [new file with mode: 0755]
source3/selftest/tests.py

diff --git a/selftest/knownfail.d/spnego_downgrade b/selftest/knownfail.d/spnego_downgrade
new file mode 100644 (file)
index 0000000..494a55f
--- /dev/null
@@ -0,0 +1 @@
+^samba3.blackbox.smbd_no_krb5.test_spnego_downgrade
index 92d058f02ba50b0084908553086e68ed2d4f3c23..fab8bdda86e88c984bd55a1fc1aba72cb4fde164 100755 (executable)
@@ -1621,6 +1621,7 @@ sub provision($$$$$$$$$)
        my $dfqconffile="$libdir/dfq.conf";
        my $errorinjectconf="$libdir/error_inject.conf";
        my $delayinjectconf="$libdir/delay_inject.conf";
+       my $globalinjectconf="$libdir/global_inject.conf";
 
        my $nss_wrapper_pl = "$ENV{PERL} $self->{srcdir}/third_party/nss_wrapper/nss_wrapper.pl";
        my $nss_wrapper_passwd = "$privatedir/passwd";
@@ -1809,6 +1810,8 @@ sub provision($$$$$$$$$)
        #it just means we ALLOW one to be configured.
        allow insecure wide links = yes
 
+       include = $globalinjectconf
+
        # Begin extra options
        $extra_options
        # End extra options
@@ -2344,6 +2347,12 @@ sub provision($$$$$$$$$)
        }
        close(DFQCONF);
 
+       unless (open(DELAYCONF, ">$globalinjectconf")) {
+               warn("Unable to open $globalinjectconf");
+               return undef;
+       }
+       close(DELAYCONF);
+
        ##
        ## create a test account
        ##
diff --git a/source3/script/tests/test_smbd_no_krb5.sh b/source3/script/tests/test_smbd_no_krb5.sh
new file mode 100755 (executable)
index 0000000..e9dbb4a
--- /dev/null
@@ -0,0 +1,46 @@
+#!/bin/sh
+
+if [ $# -lt 1 ]; then
+cat <<EOF
+Usage: test_smbd_no_krb5.sh SERVER USERNAME PASSWORD PREFIX
+EOF
+exit 1;
+fi
+
+smbclient=$1
+SERVER=$2
+USERNAME=$3
+PASSWORD=$4
+PREFIX=$5
+shift 5
+
+samba_bindir="$BINDIR"
+samba_kinit=kinit
+if test -x ${samba_bindir}/samba4kinit; then
+       samba_kinit=${samba_bindir}/samba4kinit
+fi
+
+incdir=`dirname $0`/../../../testprogs/blackbox
+. $incdir/subunit.sh
+. $incdir/common_test_fns.inc
+
+failed=0
+
+opt="--option=gensec:gse_krb5=yes -U${USERNAME}%${PASSWORD}"
+
+# check kerberos access
+test_smbclient "test_krb5" "ls" "//$SERVER/tmp" $opt -k || failed=`expr $failed + 1`
+
+# disbale krb5 globally so smbd won't accept it
+global_inject_conf=$(dirname $SMB_CONF_PATH)/global_inject.conf
+echo 'gensec:gse_krb5=no' > $global_inject_conf
+
+# verify that kerberos fails
+test_smbclient_expect_failure "smbd_no_krb5" "ls" "//$SERVER/tmp" -k $opt || failed=`expr $failed + 1`
+
+# verify downgrade to ntlmssp
+test_smbclient "test_spnego_downgrade" "ls" "//$SERVER/tmp" $opt || failed=`expr $failed + 1`
+
+echo '' > $global_inject_conf
+
+testok $0 $failed
index f3676a879a3860dad6d1a0ea2fe1b909d06f1fb8..7b600ec64a24025dabcdc18dfbc09f0c21f340cb 100755 (executable)
@@ -775,6 +775,10 @@ plantestsuite("samba3.blackbox.net_tdb", "simpleserver:local",
 plantestsuite("samba3.blackbox.smbd_error", "simpleserver:local",
               [os.path.join(samba3srcdir, "script/tests/test_smbd_error.sh")])
 
+plantestsuite("samba3.blackbox.smbd_no_krb5", "ad_member:local",
+              [os.path.join(samba3srcdir, "script/tests/test_smbd_no_krb5.sh"),
+               smbclient3, '$SERVER', "$DC_USERNAME", "$DC_PASSWORD", "$PREFIX"])
+
 plantestsuite("samba3.blackbox.durable_v2_delay", "simpleserver:local",
               [os.path.join(samba3srcdir, "script/tests/test_durable_handle_reconnect.sh")])