s4/rpc/drsuapi/writespn: check the actual error code (CID 1034691)
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 2 May 2019 23:29:37 +0000 (11:29 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 9 May 2019 22:39:27 +0000 (22:39 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source4/rpc_server/drsuapi/writespn.c

index 9a289897f3e79dd29ac2d54f3755884dfdfedf6f..c6faea39e9f9a6e7645f040a7d5a9f630c21fd8f 100644 (file)
@@ -111,8 +111,8 @@ static bool writespn_check_spn(struct drsuapi_bind_state *b_state,
                return false;
        }
 
-       ret = krb5_parse_name_flags(krb_ctx, spn, KRB5_PRINCIPAL_PARSE_NO_REALM,
-                                   &principal);
+       kerr = krb5_parse_name_flags(krb_ctx, spn, KRB5_PRINCIPAL_PARSE_NO_REALM,
+                                    &principal);
        if (kerr != 0) {
                krb5_free_context(krb_ctx);
                talloc_free(tmp_ctx);