s4-kdc: Fix Coverity ID #1373386 (Resource Leak)
authorGünther Deschner <gd@samba.org>
Tue, 27 Sep 2016 16:30:29 +0000 (18:30 +0200)
committerGünther Deschner <gd@samba.org>
Thu, 29 Sep 2016 16:30:18 +0000 (18:30 +0200)
Guenther

Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
source4/kdc/db-glue.c

index ef750a806caff92436daf96089d7f7f117fd7e2e..d7bba3d35e4f16a9e74ff39e8d95a25b8848e7af 100644 (file)
@@ -238,6 +238,7 @@ static int samba_kdc_sort_encryption_keys(struct sdb_entry_ex *entry_ex)
 
                        /* Paranoia: Do not overflow the key_data array */
                        if (idx > keys_size) {
+                               free(sorted_keys);
                                return -1;
                        }
 
@@ -250,6 +251,7 @@ static int samba_kdc_sort_encryption_keys(struct sdb_entry_ex *entry_ex)
 
        /* Paranoia: Something went wrong during data copy */
        if (idx < keys_size) {
+               free(sorted_keys);
                return -1;
        }