s4:registry: Fix size type and loop

This fixes compilation with -Wstrict-overflow=2.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source4/lib/registry/tools/regshell.c b/source4/lib/registry/tools/regshell.c
index 5308d30e84967b23deb4149dba2bdfa9540b7d5b..48251c33ea4a038f22b80749067c8b3c9c3bd8c9 100644 (file)
--- a/source4/lib/registry/tools/regshell.c
+++ b/source4/lib/registry/tools/regshell.c
@@ -428,7 +428,7 @@ static char **reg_complete_command(const char *text, int start, int end)
        /* Complete command */
        char **matches;
        size_t len, samelen=0;
-       int i, count=1;
+       size_t i, count = 1;
 
        matches = malloc_array_p(char *, MAX_COMPLETIONS);
        if (!matches) return NULL;
@@ -463,10 +463,8 @@ static char **reg_complete_command(const char *text, int start, int end)
        return matches;
 
 cleanup:
-       count--;
-       while (count >= 0) {
-               free(matches[count]);
-               count--;
+       for (i = 0; i < count; i++) {
+               free(matches[i]);
        }
        free(matches);
        return NULL;