eventlog: Fix CID 242105 Unchecked return value
authorVolker Lendecke <vl@samba.org>
Thu, 5 Apr 2018 08:11:16 +0000 (10:11 +0200)
committerVolker Lendecke <vl@samba.org>
Thu, 5 Apr 2018 14:17:13 +0000 (16:17 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/lib/eventlog/eventlog.c

index f9ac0900150fa8e4a55fa1a10c0de4f03ddeea79..cc4573c869ceb4edc80ce94ee8ba2fc9e045b622 100644 (file)
@@ -966,7 +966,10 @@ NTSTATUS evlog_tdb_entry_to_evt_entry(TALLOC_CTX *mem_ctx,
                        return NT_STATUS_INVALID_SID;
                }
                if (len > 0) {
-                       string_to_sid(&e->UserSid, sid_str);
+                       bool ok = string_to_sid(&e->UserSid, sid_str);
+                       if (!ok) {
+                               return NT_STATUS_INVALID_SID;
+                       }
                }
        }