s4:repl_meta_data LDB module - don't remove the partition control twice
authorMatthias Dieter Wallnöfer <mdw@samba.org>
Sat, 5 Mar 2011 12:56:10 +0000 (13:56 +0100)
committerMatthias Dieter Wallnöfer <mdw@samba.org>
Thu, 10 Mar 2011 10:12:05 +0000 (11:12 +0100)
"controls" is already the controls list which has the partition control
removed. It is generated by "ldb_controls_except_specified" in line 378.

source4/dsdb/samdb/ldb_modules/repl_meta_data.c

index fb87fd3265786e04bf7b1bcf4ac696c683fd55cb..81b06fd6bac88f7a56bf07e57d0b08236bd13f07 100644 (file)
@@ -452,8 +452,7 @@ static int replmd_op_callback(struct ldb_request *req, struct ldb_reply *ares)
                 * common path.  Other cases will have it cleaned up
                 * eventually with the ares */
                talloc_free(partition_ctrl);
-               return ldb_module_done(ac->req,
-                                      ldb_controls_except_specified(controls, ares, partition_ctrl),
+               return ldb_module_done(ac->req, controls,
                                       ares->response, LDB_SUCCESS);
        }
 }