Output examples

bin/smbtorture //172.31.9.192/torture -Uadministrator%geheim 'base.delaywrite-legacy' 2>&1 | tee out.legacy-192
bin/smbtorture //172.31.9.219/torture -Uadministrator%A1b2C3d4 'base.delaywrite-modern' 2>&1 | tee out.modern-219
bin/smbtorture //172.31.9.187/torture -Uadministrator%A1b2C3d4 'base.delaywrite-modern' 2>&1 | tee out.modern-187

172.31.9.192 is Windows 2000 SP4
172.31.9.219 is Windows 2008 R2
172.31.9.187 is Windows 2016

modern and legacy delaywrite => 0.5 sec delay

TODO: smb2_server: set req->do_encryption = true earlier

TODO: tests

https://blogs.msdn.microsoft.com/openspecification/2012/10/05/encryption-in-smb-3-0-a-protocol-perspective/

The sender encrypts the message if any of the following conditions is
satisfied:

    If the sender is sending a response to an encrypted request.
    If Session.EncryptData is TRUE and the request or response being
sent is not NEGOTIATE.
    If Session.EncryptData is FALSE, the request or response being sent
is not NEGOTIATE or SESSION_SETUP or TREE_CONNECT, and
<TreeConnect|Share>.EncryptData is TRUE.

[MS-SMB2] 3.3.4.1.4 Encrypting the Message

 If Connection.Dialect belongs to the SMB 3.x dialect family and
 Connection.ClientCapabilities includes the SMB2_GLOBAL_CAP_ENCRYPTION
 bit, the server MUST encrypt the message before sending, if any of the
 following conditions are satisfied:

 - If the message being sent is any response to a client request for which
   Request.IsEncrypted is TRUE.

 - If Session.EncryptData is TRUE and the response being sent is not
   SMB2_NEGOTIATE or SMB2 SESSION_SETUP.

 - If Session.EncryptData is FALSE, the response being sent is not
   SMB2_NEGOTIATE or SMB2 SESSION_SETUP or SMB2 TREE_CONNECT, and
   Share.EncryptData for the share associated with the TreeId in the SMB2
   header of the response is TRUE.

 The server MUST encrypt the message as specified in section 3.1.4.3,
 before sending it to the client.

sq modern and legacy delaywrite selftest

sq test_delaywrite_delaywrite1

modern and legacy delaywrite

modern and legacy delaywrite => legacy works against w2k

legacy lower time to 1 sec?

Revert "test_delayed_write_update4 HACKS ..."

This reverts commit 092f769e1c75012a51949694da06e3c31f33198e.

test_delayed_write_update4 HACKS ...

Revert "HACK w2k behaviour"

This reverts commit 8d751a927ea95c7b9d1ae013237cdb1a049b7d1a.

HACK w2k behaviour

MSG_SMB_FILE_PATHINFO

sq smb2.timestamps

s4:libcli: cleanup smbcli_deltree()

We already have the 'status' of smbcli_unlink(), so
we can check that directly.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

TODO smbd: allow durable opens together with stat opens

TODO: explicit tests

fix mark_file_modified for new Windows >= 2008R2 behaviour

test_timestamp_delaywrite1a/b durable-reconnect

sq source4/torture/smb2/timestamps.c

sq test_smb_timestamp_writetime1 source4/torture/util_smb_timestamps.c

sq source4/torture/smb2/timestamps.c

revert test_delayed_write_update3

Revert "break test_delayed_write_update with a PATHINFO call..."

This reverts commit 713123bda5075672afcb211a6742950ad968b146.

sq test_durable_open_delaywrite1 source4/torture/smb2/timestamps.c

sq test_delaywrite_delaywrite1 source4/torture/basic/delaywrite.c

revert source4/torture/smb2/durable_open.c

test_smb_timestamp_writetime1 source4/torture/util_smb_timestamps.c

Revert "test_delayed_write_update TODO: research PATHINFO => DEFER_CHANGE_ON_CLOSE"

This reverts commit c666c2a9f1cd123ef4ba2c4d60ff63eb1bfaec2f.

test_delayed_write_update TODO: research PATHINFO => DEFER_CHANGE_ON_CLOSE

sq source4/torture/basic/delaywrite.c

sq source4/torture/smb2/timestamps.c

source4/torture/util_writetime.c test_delay_writetime1

source4/torture/smb2/timestamps.c

works for SMB1 and SMB2

break test_delayed_write_update with a PATHINFO call...

still works SMB1

works SMB1

works for SMB2, fails SMB1

SMB1:
no update at all.
What's the difference to 'delayed update of write time' test???

sq source4/torture/util_writetime.c source4/torture/smb2/durable_open.c

test_delaywrite_delaywrite1 SMB1

source4/torture/util_writetime.c

revert source4/torture/smb2/durable_v2_open.c

smbd: SMB2 write time mode...???

TODO source4/torture/smb2/durable_open.c

TODO source4/torture/smb2/durable_open.c

TODO source4/torture/smb2/durable_open.c

TODO source4/torture/smb2/durable_open.c

HACK source4/torture/basic/delaywrite.c

TODO: bin/smbtorture //172.31.9.187/torture -Uadministrator%A1b2C3d4 smb2.durable-v2-open.delaywrite1

https://bugzilla.samba.org/show_bug.cgi?id=13541

Revert "s3:smbXsrv_open: initialize smbXsrv_open_global->lock_sequence_array with 0xFF"

This reverts commit cefc0f33582cf35d38abfcfe3e40bc74e8f7dada.

Revert "s3:smb2_lock: pass in_lock_sequence to smbd_smb2_lock_send()"

This reverts commit 15a96df54a351516f6e00d5ae46e961452c5b69a.

Revert "TODO test pidl/ServerNDR: ignore functions marked as "todo""

This reverts commit 76e32fa6f74d12b64ac731b558b9bdae67dcb019.

Revert "dir ~NTCREATEX_SHARE_ACCESS_DELETE"

This reverts commit bed7b5171fad319e3b58f70d1a510dce68c1bdd8.

TODO test pidl/ServerNDR: ignore functions marked as "todo"

TODO smb2_tcon: add some share flags/capabilities options (Default:off)

s3:smb2_lock: pass in_lock_sequence to smbd_smb2_lock_send()

Take the value from the client if the dialect is SMB2_10 or higher,
otherwise default to 0.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

s3:smbXsrv_open: initialize smbXsrv_open_global->lock_sequence_array with 0xFF

This does not match the current documentation, but is very likely the
right thing to do.

If we would match the documentation and initialize with 0x00,
we would return STATUS_SUCCESS without doing any locks.
If the client also follows the documentation and starts
with a lock_sequence of 0 for the first operation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>

Revert "oplock..."

This reverts commit 143a2d1b6ee978c1fdf21a30804e7fedef0c1bd5.

oplock...

smbd-adm

smbd-adm

HACK: add smbd-adm.txt

Revert "TODO: all ncs..."

This reverts commit 2c2a8c860f91e8fa5cccb9eb561f17aa3e9f9ea1.

TODO: all ncs...

Revert "s4 fix it?"

This reverts commit ecbc6e081d37b4936f750b9b958f13c9b5ae3325.

Revert "HACK pass s4 create_action..."

This reverts commit 8b4880e53acedc2d3b6734c43154ed5be216e1f2.

HACK pass s4 create_action...

s4 fix it?

Revert "09b - TODO: allow durable with delete_on_close in vfswrap_default_durable_disconnect"

This reverts commit a13f5015e750eb59336018d854c42306dab85cd6.

Revert "TODO smbXsrv_open_global idl: add persistent"

This reverts commit 85bf07a0444108c8d0f83ca53a3798b12f0109da.

Revert "TODO smb2_tcon: add some share flags/capabilities options (Default:off)"

This reverts commit 9fb1b5025fe779f8664a44cb6490d1db6e2cdbcf.

Revert "BROKEN: TODO smbXsrv_open infra: add "file_name/path_name/share_name = <TODO>" and DEBUG"

This reverts commit b0e1f4b2cb160211fffc1800f8309b40d8d9dcb2.

Revert "HACK debug replay/channel_sequence"

This reverts commit 46ce191a9bf9321251ea601a9b3ba7b48c5d5ccb.

Revert "HACK disconnect after 2 writes"

This reverts commit eaa7023f865be73483a99ff203d1dbfb3e180ef9.

HACK disconnect after 2 writes

HACK debug replay/channel_sequence

BROKEN: TODO smbXsrv_open infra: add "file_name/path_name/share_name = <TODO>" and DEBUG

was 55159a5499d4341d601b38d1e03bff7280053343

TODO smb2_tcon: add some share flags/capabilities options (Default:off)

TODO smbXsrv_open_global idl: add persistent

MAYBE squash with "smbXsrv_open_global idl: add more SMB 2.10/3.00 stuff TODO: more"

09b - TODO: allow durable with delete_on_close in vfswrap_default_durable_disconnect

Revert "TODO later? smbXsrv_open_close_all"

This reverts commit be146b939400dda6d2ec5b77d9f6224ce6363927.

TODO later? smbXsrv_open_close_all

TODO: add server-id-disconnected.txt

TODO.durable

add questions.txt

durable.txt

connection_struct.txt

cmd.txt

do_out.sh

Revert "TODO make sure the gid doesn't belong to a user s3:passdb: return ID_TYPE_BOTH for builtin and wellknown sids from pdb_default_sid_to_id()"

This reverts commit affad381e7baff28550f5097711235e3ca041596.

Revert "TODO(richtig so? - oder auch user?) s3:passdb: set ID_TYPE_BOTH for groups from own sam in pdb_defaul_sid_to_id()"

This reverts commit e2becf56263e1d6b168be6a38ea436425e4a48e8.

TODO(richtig so? - oder auch user?) s3:passdb: set ID_TYPE_BOTH for groups from own sam in pdb_defaul_sid_to_id()

This way, one can set groups as file owners.

Signed-off-by: Michael Adam <obnox@samba.org>

TODO make sure the gid doesn't belong to a user s3:passdb: return ID_TYPE_BOTH for builtin and wellknown sids from pdb_default_sid_to_id()

This allows e.g. for BUILTIN\\administrators to be taken as file owner (user).

Signed-off-by: Michael Adam <obnox@samba.org>

s3:registry: Fix possible memory leak in _reg_perfcount_multi_sz_from_tdb()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 11 04:43:15 CEST 2018 on sn-devel-144

s3:libads: Fix memory leaks in ads_krb5_chg_password()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

s3:client: Avoid a possible fd leak in do_get()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

s4:lib: Fix a possible fd leak in gp_get_file()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

s3:utils: Do not leak memory in new_user()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

s3:utils: Do not overflow the destination buffer in net_idmap_restore()

Found by covsan.

error[invalidScanfFormatWidth]: Width 128 given in format string (no. 2)
is larger than destination buffer 'sid_string[128]', use %127s to
prevent overflowing it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

s3:passdb: Don't leak memory on error in fetch_ldap_pw()

Found by covscan.

A candidate to use tallac ...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

wbinfo: Free memory when we leave wbinfo_dsgetdcname()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>