metze/samba/wip.git
10 years agoHACK 500 => 498 still works... master3-testing
Stefan Metzmacher [Tue, 18 Feb 2014 12:41:56 +0000 (13:41 +0100)]
HACK 500 => 498 still works...

10 years agoHACK 500 OK
Stefan Metzmacher [Tue, 18 Feb 2014 12:41:56 +0000 (13:41 +0100)]
HACK 500 OK

10 years agoHACK 499 still triggers ERRSRV/ERRerror
Stefan Metzmacher [Tue, 18 Feb 2014 12:41:56 +0000 (13:41 +0100)]
HACK 499 still triggers ERRSRV/ERRerror

10 years agoHACK CLI_BUFFER_SIZE => 0
Stefan Metzmacher [Tue, 18 Feb 2014 11:55:23 +0000 (12:55 +0100)]
HACK CLI_BUFFER_SIZE => 0

10 years agoRevert "DISCUSS fix LARGE_WRITEX_BUFFER_SIZE"
Stefan Metzmacher [Tue, 18 Feb 2014 13:03:21 +0000 (14:03 +0100)]
Revert "DISCUSS fix LARGE_WRITEX_BUFFER_SIZE"

This reverts commit 685eea06bfcf67e894be0915673bfebab33449fe.

10 years agoDISCUSS fix LARGE_WRITEX_BUFFER_SIZE
Stefan Metzmacher [Fri, 6 Dec 2013 12:56:45 +0000 (13:56 +0100)]
DISCUSS fix LARGE_WRITEX_BUFFER_SIZE

10 years agorevert to f52a4fd51a6023ab51f985b4e51c7043c1eea43f
Stefan Metzmacher [Mon, 9 Dec 2013 13:39:31 +0000 (14:39 +0100)]
revert to f52a4fd51a6023ab51f985b4e51c7043c1eea43f

10 years agosq smb2_set_operation_credit
Stefan Metzmacher [Thu, 5 Dec 2013 14:33:57 +0000 (15:33 +0100)]
sq smb2_set_operation_credit

10 years agosq hack avoid tevent_req_create on read
Stefan Metzmacher [Thu, 5 Dec 2013 14:11:55 +0000 (15:11 +0100)]
sq hack avoid tevent_req_create on read

10 years agohack skip smbd_smb2_request_verify* on read
Stefan Metzmacher [Thu, 5 Dec 2013 13:18:53 +0000 (14:18 +0100)]
hack skip smbd_smb2_request_verify* on read

10 years agohack avoid tevent_req_create on read
Stefan Metzmacher [Thu, 5 Dec 2013 12:37:50 +0000 (13:37 +0100)]
hack avoid tevent_req_create on read

10 years agoHACK skip smbd_smb2_request_verify_*
Stefan Metzmacher [Thu, 5 Dec 2013 12:21:01 +0000 (13:21 +0100)]
HACK skip smbd_smb2_request_verify_*

10 years agohack smbd_smb2_flush_send_queue
Stefan Metzmacher [Thu, 5 Dec 2013 12:20:45 +0000 (13:20 +0100)]
hack smbd_smb2_flush_send_queue

10 years agoHACK skip smbd_smb2_request_validate
Stefan Metzmacher [Thu, 5 Dec 2013 11:31:10 +0000 (12:31 +0100)]
HACK skip smbd_smb2_request_validate

10 years agohack avoid tevent_req_create on write
Stefan Metzmacher [Thu, 5 Dec 2013 12:07:18 +0000 (13:07 +0100)]
hack avoid tevent_req_create on write

10 years agoRevert "HACK skip smbd_smb2_request_validate"
Stefan Metzmacher [Thu, 5 Dec 2013 11:31:25 +0000 (12:31 +0100)]
Revert "HACK skip smbd_smb2_request_validate"

This reverts commit c7283e4264b1f24a51cafc3fb196a7380ea2862c.

10 years agoHACK skip smbd_smb2_request_validate
Stefan Metzmacher [Thu, 5 Dec 2013 11:31:10 +0000 (12:31 +0100)]
HACK skip smbd_smb2_request_validate

10 years agotevent_req deferr tevent_create_immediate
Stefan Metzmacher [Thu, 5 Dec 2013 09:36:10 +0000 (10:36 +0100)]
tevent_req deferr tevent_create_immediate

10 years agoread/write avoid tevent_req_post()
Stefan Metzmacher [Thu, 5 Dec 2013 09:25:40 +0000 (10:25 +0100)]
read/write avoid tevent_req_post()

10 years agouse epoll
Stefan Metzmacher [Wed, 4 Dec 2013 22:37:06 +0000 (23:37 +0100)]
use epoll

10 years agonoop tevent_debug()
Stefan Metzmacher [Wed, 4 Dec 2013 21:55:11 +0000 (22:55 +0100)]
noop tevent_debug()

10 years agos3:smb2_server: make use of unlikely()
Stefan Metzmacher [Wed, 4 Dec 2013 21:12:23 +0000 (22:12 +0100)]
s3:smb2_server: make use of unlikely()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agono sha
Stefan Metzmacher [Tue, 19 Nov 2013 06:41:55 +0000 (07:41 +0100)]
no sha

10 years agoRevert "stackframe-children1"
Stefan Metzmacher [Tue, 15 Oct 2013 10:52:36 +0000 (12:52 +0200)]
Revert "stackframe-children1"

This reverts commit 8f71c6781ffe6652fa34cc68c5eeda4594f9eeeb.

10 years agoRevert "stackframe-children2"
Stefan Metzmacher [Tue, 15 Oct 2013 10:52:33 +0000 (12:52 +0200)]
Revert "stackframe-children2"

This reverts commit 7a17fcaa372749e6873c3a85098519d6ddb3e41b.

10 years agostackframe-children2
Stefan Metzmacher [Sat, 12 Oct 2013 00:11:52 +0000 (02:11 +0200)]
stackframe-children2

10 years agostackframe-children1
Stefan Metzmacher [Sat, 12 Oct 2013 00:11:38 +0000 (02:11 +0200)]
stackframe-children1

10 years agoRevert "TODO writev_send not always TEVENT_FD_READ"
Stefan Metzmacher [Wed, 2 Oct 2013 13:17:57 +0000 (15:17 +0200)]
Revert "TODO writev_send not always TEVENT_FD_READ"

This reverts commit a4c07bc7aa06959596084178610011d02b3cf543.

10 years agoTODO writev_send not always TEVENT_FD_READ
Stefan Metzmacher [Wed, 2 Oct 2013 13:08:12 +0000 (15:08 +0200)]
TODO writev_send not always TEVENT_FD_READ

10 years agoRevert "rpc vampire keytab trusts"
Stefan Metzmacher [Tue, 15 Sep 2009 05:24:18 +0000 (07:24 +0200)]
Revert "rpc vampire keytab trusts"

This reverts commit 637db566d41add555dc73093dca3083655bd61a1.

10 years agorpc vampire keytab trusts
Stefan Metzmacher [Wed, 26 Aug 2009 10:30:33 +0000 (12:30 +0200)]
rpc vampire keytab trusts

10 years agoRevert "create blob debugging"
Stefan Metzmacher [Wed, 19 Aug 2009 18:23:27 +0000 (20:23 +0200)]
Revert "create blob debugging"

This reverts commit 01eda97c4c4814fac30cffdd0ae06fbba6c0d754.

10 years agocreate blob debugging
Stefan Metzmacher [Wed, 12 Aug 2009 20:03:05 +0000 (22:03 +0200)]
create blob debugging

10 years agoRevert "test send oplock break"
Stefan Metzmacher [Mon, 10 Aug 2009 11:42:27 +0000 (13:42 +0200)]
Revert "test send oplock break"

This reverts commit 6ee156076b838309061d854556727273d6546af1.

10 years agotest send oplock break
Stefan Metzmacher [Fri, 7 Aug 2009 13:22:10 +0000 (15:22 +0200)]
test send oplock break

10 years agoRevert "async_sock: add readv_send/recv()"
Stefan Metzmacher [Mon, 14 Oct 2013 08:05:20 +0000 (10:05 +0200)]
Revert "async_sock: add readv_send/recv()"

This reverts commit 1df81b7dd0f1ae7a167ef4405c046d43b56bbc04.

10 years agoasync_sock: add readv_send/recv()
Stefan Metzmacher [Thu, 12 Mar 2009 11:57:08 +0000 (12:57 +0100)]
async_sock: add readv_send/recv()

The design is that the callback allocates the buffers
and provides iovec arrays which will be filled,
until an iovec count of 0 is returned or an error happens.

metze

10 years agoHACK panic sendfile buffer size and smbd_smb2_generate_outbody
Stefan Metzmacher [Wed, 4 Dec 2013 14:08:06 +0000 (15:08 +0100)]
HACK panic sendfile buffer size and smbd_smb2_generate_outbody

10 years agos3:smb2_server: only allocate the required buffer in the smb2 recvfile() code path
Stefan Metzmacher [Fri, 15 Nov 2013 08:12:40 +0000 (09:12 +0100)]
s3:smb2_server: only allocate the required buffer in the smb2 recvfile() code path

This way the buffer will likely be allocated within the existing talloc_pool,
which avoids one malloc() per request.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smb2_server: prepare smbd_smb2_request_verify_sizes() for the optimized recvfile...
Stefan Metzmacher [Mon, 18 Nov 2013 12:46:10 +0000 (13:46 +0100)]
s3:smb2_server: prepare smbd_smb2_request_verify_sizes() for the optimized recvfile() case

For recvfile we haven't read and may not allocated the dyn buffer.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smb2_write: allow SMBD_SMB2_IN_DYN_LEN() to be 0 for the recvfile case.
Stefan Metzmacher [Mon, 18 Nov 2013 12:45:37 +0000 (13:45 +0100)]
s3:smb2_write: allow SMBD_SMB2_IN_DYN_LEN() to be 0 for the recvfile case.

For recvfile we haven't read and may not allocated the dyn buffer.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agoTODO print_spool_write vs. recvfile
Stefan Metzmacher [Wed, 4 Dec 2013 09:41:26 +0000 (10:41 +0100)]
TODO print_spool_write vs. recvfile

10 years agos3:smb2_write: reject writes to named pipes with recvfile
Stefan Metzmacher [Wed, 4 Dec 2013 14:52:40 +0000 (15:52 +0100)]
s3:smb2_write: reject writes to named pipes with recvfile

This looks strange but matches the SMB1 case.

We may want to clean this in a better way in both places later.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:lib: use stack buffers in drain_socket() and default_sys_recvfile()
Stefan Metzmacher [Thu, 5 Dec 2013 10:20:49 +0000 (11:20 +0100)]
s3:lib: use stack buffers in drain_socket() and default_sys_recvfile()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agotalloc: check for TALLOC_GET_TYPE_ABORT_NOOP
Stefan Metzmacher [Thu, 5 Dec 2013 07:36:13 +0000 (08:36 +0100)]
talloc: check for TALLOC_GET_TYPE_ABORT_NOOP

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agotalloc: avoid a function call in TALLOC_FREE() if possible.
Stefan Metzmacher [Wed, 4 Dec 2013 14:35:37 +0000 (15:35 +0100)]
talloc: avoid a function call in TALLOC_FREE() if possible.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agoTODO talloc: fix compiler warning
Stefan Metzmacher [Wed, 20 Nov 2013 08:58:09 +0000 (09:58 +0100)]
TODO talloc: fix compiler warning

Make it explicit that we exit the loop on depth == 0
and don't...

10 years agotalloc: inline talloc_get_name()
Stefan Metzmacher [Wed, 4 Dec 2013 22:22:04 +0000 (23:22 +0100)]
talloc: inline talloc_get_name()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agotalloc: inline more static functions
Stefan Metzmacher [Wed, 20 Nov 2013 08:57:58 +0000 (09:57 +0100)]
talloc: inline more static functions

We need the code to be as fast as possible.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agoRevert "LATER/DISCUSS: s3:client: add progress reporting to cli_pull/cli_push"
Stefan Metzmacher [Wed, 14 Aug 2013 10:05:03 +0000 (12:05 +0200)]
Revert "LATER/DISCUSS: s3:client: add progress reporting to cli_pull/cli_push"

This reverts commit e25ac87a8505c2be3494fc53d3ba7448ee07f551.

10 years agoLATER/DISCUSS: s3:client: add progress reporting to cli_pull/cli_push
Stefan Metzmacher [Wed, 14 Aug 2013 08:47:38 +0000 (10:47 +0200)]
LATER/DISCUSS: s3:client: add progress reporting to cli_pull/cli_push

DISCUSS: d_printf vs. DEBUG
DISCUSS: timeval vs. time_mono

10 years agoRevert "DEBUG credits..."
Stefan Metzmacher [Wed, 14 Aug 2013 07:18:16 +0000 (09:18 +0200)]
Revert "DEBUG credits..."

This reverts commit fef234225a7f714f7871e823a944efd7c3f3ca3a.

10 years agoRevert "DEBUG cli_push/cli_pull"
Stefan Metzmacher [Wed, 14 Aug 2013 07:18:13 +0000 (09:18 +0200)]
Revert "DEBUG cli_push/cli_pull"

This reverts commit de391c788b9a7311c73fb81e910c12f2f419d921.

10 years agoDEBUG cli_push/cli_pull
Stefan Metzmacher [Wed, 14 Aug 2013 06:48:40 +0000 (08:48 +0200)]
DEBUG cli_push/cli_pull

10 years agoDEBUG credits...
Stefan Metzmacher [Wed, 14 Aug 2013 06:48:21 +0000 (08:48 +0200)]
DEBUG credits...

10 years agos4: smbtorture: Add a proper change_notify going async followed by tdis test.
Jeremy Allison [Mon, 24 Feb 2014 18:44:59 +0000 (10:44 -0800)]
s4: smbtorture: Add a proper change_notify going async followed by tdis test.

[Bug 10344] SessionLogoff on a signed connection with an outstanding notify request crashes smbd.

https://bugzilla.samba.org/show_bug.cgi?id=10344

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar 12 20:12:58 CET 2014 on sn-devel-104

10 years agos4: smbtorture: Update the torture_smb2_notify_ulogoff test to demonstrate the problem.
Jeremy Allison [Tue, 28 Jan 2014 22:07:26 +0000 (14:07 -0800)]
s4: smbtorture: Update the torture_smb2_notify_ulogoff test to demonstrate the problem.

[Bug 10344] SessionLogoff on a signed connection with an outstanding notify request crashes smbd.

https://bugzilla.samba.org/show_bug.cgi?id=10344

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smb2_tcon: cancel and wait for pending requests on tdis
Stefan Metzmacher [Mon, 10 Mar 2014 08:53:18 +0000 (09:53 +0100)]
s3:smb2_tcon: cancel and wait for pending requests on tdis

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10344
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos3:smb2_sesssetup: cancel and wait for pending requests on logoff
Stefan Metzmacher [Mon, 10 Mar 2014 08:53:18 +0000 (09:53 +0100)]
s3:smb2_sesssetup: cancel and wait for pending requests on logoff

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10344

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos3:smb2_tcon: split smbd_smb2_tdis into an async *_send/recv pair.
Jeremy Allison [Mon, 10 Mar 2014 08:53:18 +0000 (09:53 +0100)]
s3:smb2_tcon: split smbd_smb2_tdis into an async *_send/recv pair.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10344

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smb2_sesssetup: split smbd_smb2_logoff into an async *_send/recv pair.
Jeremy Allison [Mon, 10 Mar 2014 08:53:18 +0000 (09:53 +0100)]
s3:smb2_sesssetup: split smbd_smb2_logoff into an async *_send/recv pair.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10344

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smb2_lock: return RANGE_NOT_LOCKED instead of CANCELLED for logoff and tdis
Stefan Metzmacher [Mon, 10 Mar 2014 08:47:11 +0000 (09:47 +0100)]
s3:smb2_lock: return RANGE_NOT_LOCKED instead of CANCELLED for logoff and tdis

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos3:smb2_lock: fix whitespaces/tabs in smbd_smb2_lock_cancel()
Stefan Metzmacher [Mon, 10 Mar 2014 08:43:35 +0000 (09:43 +0100)]
s3:smb2_lock: fix whitespaces/tabs in smbd_smb2_lock_cancel()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos4:torture/smb2: accept NT_STATUS_RANGE_NOT_LOCKED after smb2_logoff/tdis
Stefan Metzmacher [Fri, 7 Mar 2014 11:31:19 +0000 (12:31 +0100)]
s4:torture/smb2: accept NT_STATUS_RANGE_NOT_LOCKED after smb2_logoff/tdis

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos3-net: add a new "net ads kerberos pac save" tool.
Günther Deschner [Tue, 11 Mar 2014 17:16:40 +0000 (18:16 +0100)]
s3-net: add a new "net ads kerberos pac save" tool.

Use "filename=string" to define a file where to save the unencrypted PAC to.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Mar 12 13:02:59 CET 2014 on sn-devel-104

10 years agos3-net: modify the current "net ads kerberos pac" command.
Günther Deschner [Tue, 11 Mar 2014 17:14:39 +0000 (18:14 +0100)]
s3-net: modify the current "net ads kerberos pac" command.

Rename it to "net ads kerberos pac dump" and add a "type=num" option to allow
dumping of individial pac buffer types. Ommitting type= or using type=0 will
dump the whole PAC structure on stdout.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agos3-kerberos: let kerberos_return_pac() return a PAC container.
Günther Deschner [Tue, 11 Mar 2014 17:07:11 +0000 (18:07 +0100)]
s3-kerberos: let kerberos_return_pac() return a PAC container.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agos3-kerberos: return a full PAC in kerberos_return_pac().
Günther Deschner [Fri, 21 Feb 2014 17:56:04 +0000 (18:56 +0100)]
s3-kerberos: return a full PAC in kerberos_return_pac().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agos3-net: allow to provide custom local_service in "net ads kerberos pac".
Günther Deschner [Tue, 11 Mar 2014 15:34:36 +0000 (16:34 +0100)]
s3-net: allow to provide custom local_service in "net ads kerberos pac".

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agos3-net: change the way impersonation principals are used in "net ads kerberos pac".
Günther Deschner [Mon, 10 Mar 2014 14:11:18 +0000 (15:11 +0100)]
s3-net: change the way impersonation principals are used in "net ads kerberos pac".

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agoauth/kerberos: fix a typo.
Günther Deschner [Mon, 3 Mar 2014 11:14:51 +0000 (12:14 +0100)]
auth/kerberos: fix a typo.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agos3-libads: pass down local_service to kerberos_return_pac().
Günther Deschner [Fri, 17 Jan 2014 13:29:03 +0000 (14:29 +0100)]
s3-libads: pass down local_service to kerberos_return_pac().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agoCVE-2013-6442: s3:smbcacls - ensure we don't lose an existing ACL when setting owner...
Jeremy Allison [Wed, 18 Dec 2013 21:56:18 +0000 (13:56 -0800)]
CVE-2013-6442: s3:smbcacls - ensure we don't lose an existing ACL when setting owner or group owner.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10327
Bug 10327 - CVE-2013-6442: smbcacls --chown | --chgrp dacl regression

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Mar 11 22:55:54 CET 2014 on sn-devel-104

10 years agogencache: Add gencache values to memcache
Volker Lendecke [Mon, 10 Mar 2014 14:41:32 +0000 (15:41 +0100)]
gencache: Add gencache values to memcache

gencache_parse calling tdb shows up in profiles when we do a lot of open/close
traffic with large ACLs. For every file we convert unix ids to sids, and in the
domain member case this goes through gencache.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 11 19:56:47 CET 2014 on sn-devel-104

10 years agovfs_catia: add chmod()
Ralph Boehme [Mon, 10 Mar 2014 16:14:38 +0000 (17:14 +0100)]
vfs_catia: add chmod()

Clients using UNIX extensions need chmod() to go through catia.

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Mar 11 13:39:17 CET 2014 on sn-devel-104

10 years agoAdd usable stream name defines
Ralph Boehme [Mon, 13 Jan 2014 13:03:45 +0000 (14:03 +0100)]
Add usable stream name defines

Add stream name defines that are usable with Samba's way of storing
stream names internally.

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
10 years agoFix a typo
Ralph Boehme [Fri, 14 Feb 2014 16:38:25 +0000 (17:38 +0100)]
Fix a typo

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
10 years agosamba-tool: make provision check for bind version
Garming Sam [Thu, 19 Dec 2013 02:06:51 +0000 (15:06 +1300)]
samba-tool: make provision check for bind version

(small corrections and TODO added following Jelmer's review by abartlet)
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Change-Id: Iba9a709641dad9f2ae05df0b26ac4cd2ebfc84f0
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Mar  9 02:52:50 CET 2014 on sn-devel-104

10 years agobuild: Make order of arguments clearer by explicitly making the list of functions...
Andrew Bartlett [Thu, 6 Mar 2014 23:05:19 +0000 (12:05 +1300)]
build: Make order of arguments clearer by explicitly making the list of functions to look for a python list

Change-Id: I19bbd3b34548258201dabdc0ec8dc049e28d0049
Reviewed-by: David Disseldorp <ddiss@samba.org>
Tested-by: Thomas Schulz <schulz@adi.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Mar  8 05:53:08 CET 2014 on sn-devel-104

10 years agobuild: Do not rely on sys.platform for ACL tests, combine UnixWare and Solaris ACL...
Andrew Bartlett [Wed, 5 Mar 2014 02:06:02 +0000 (15:06 +1300)]
build: Do not rely on sys.platform for ACL tests, combine UnixWare and Solaris ACL tests

This avoids issues with whatever sys.platform may return, fixes the
order of arguments to the CHECK_FUNCS_IN call, and only runs after
Linux-style POSIX ACL detection fails.

Andrew Bartlett

Change-Id: I930dff1e03c1cd1ceb8f3a35823ceb805694b66a
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Tested-by: Thomas Schulz <schulz@adi.com>
10 years agoFor FSRVP use textual error messages instead of hex error codes
Noel Power [Thu, 6 Mar 2014 11:57:45 +0000 (11:57 +0000)]
For FSRVP use textual error messages instead of hex error codes

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Mar  8 03:52:44 CET 2014 on sn-devel-104

10 years agoAdd missing FSRVP_E_UNSUPPORTED_CONTEXT constant
Noel Power [Thu, 6 Mar 2014 14:02:26 +0000 (14:02 +0000)]
Add missing FSRVP_E_UNSUPPORTED_CONTEXT constant

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos3-kerberos: remove unused kdc_name from create_local_private_krb5_conf_for_domain().
Günther Deschner [Fri, 7 Mar 2014 13:47:31 +0000 (14:47 +0100)]
s3-kerberos: remove unused kdc_name from create_local_private_krb5_conf_for_domain().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Mar  7 18:43:57 CET 2014 on sn-devel-104

10 years agos3-kerberos: remove print_kdc_line() completely.
Günther Deschner [Mon, 13 Jan 2014 14:59:26 +0000 (15:59 +0100)]
s3-kerberos: remove print_kdc_line() completely.

Just calling print_canonical_sockaddr() is sufficient, as it already deals with
ipv6 as well. The port handling, which was only done for IPv6 (not IPv4), is
removed as well. It was pointless because it always derived the port number from
the provided address which was either a SMB (usually port 445) or LDAP
connection. No KDC will ever run on port 389 or 445 on a Windows/Samba DC.
Finally, the kerberos libraries that we support and build with, can deal with
ipv6 addresses in krb5.conf, so we no longer put the (unnecessary) burden of
resolving the DC name on the kerberos library anymore.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agos4:lib/socket: simplify iface_list_wildcard() and its callers
Stefan Metzmacher [Thu, 27 Feb 2014 09:28:23 +0000 (10:28 +0100)]
s4:lib/socket: simplify iface_list_wildcard() and its callers

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10464
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Change-Id: Ib317d71dea01fc8ef6b6a26455f15a8a175d59f6
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Mar  7 02:18:17 CET 2014 on sn-devel-104

10 years agos4:lib/socket: use the same logic in iface_list_wildcard() as in smbd
Stefan Metzmacher [Thu, 27 Feb 2014 09:18:35 +0000 (10:18 +0100)]
s4:lib/socket: use the same logic in iface_list_wildcard() as in smbd

If we have ipv6 support we should listen on "::" too.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10464
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Change-Id: I8ce185d5070280149bee9fd33010443be9031089
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agopidl-waf: Only install Yapp::Driver if it is not available.
Andreas Schneider [Fri, 28 Feb 2014 15:00:54 +0000 (16:00 +0100)]
pidl-waf: Only install Yapp::Driver if it is not available.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Mar  6 23:30:47 CET 2014 on sn-devel-104

10 years agopidl-waf: Check for system perl(Parse::Yapp::Driver).
Andreas Schneider [Fri, 28 Feb 2014 14:59:45 +0000 (15:59 +0100)]
pidl-waf: Check for system perl(Parse::Yapp::Driver).

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopidl-waf: Add a function to check for a system perl module.
Andreas Schneider [Fri, 28 Feb 2014 14:59:41 +0000 (15:59 +0100)]
pidl-waf: Add a function to check for a system perl module.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopidl-waf: Do not glob to install pidl modules.
Andreas Schneider [Fri, 28 Feb 2014 14:55:46 +0000 (15:55 +0100)]
pidl-waf: Do not glob to install pidl modules.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopidl-waf: Install pidl modules to the perl vendorlib directory.
Andreas Schneider [Fri, 28 Feb 2014 14:53:10 +0000 (15:53 +0100)]
pidl-waf: Install pidl modules to the perl vendorlib directory.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopidl-waf: Remove unused variable pidl_src.
Andreas Schneider [Fri, 28 Feb 2014 14:54:09 +0000 (15:54 +0100)]
pidl-waf: Remove unused variable pidl_src.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoautobuild: Set perl vendorlib direcotry.
Andreas Schneider [Wed, 5 Mar 2014 15:27:15 +0000 (16:27 +0100)]
autobuild: Set perl vendorlib direcotry.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agobuildtools: Add perl vendorlib configure option.
Andreas Schneider [Fri, 28 Feb 2014 14:50:02 +0000 (15:50 +0100)]
buildtools: Add perl vendorlib configure option.

After this patch has been pushed, we need to change autobuild to compile
with this option or we will not be able to install pidl.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agobuildtools: Rename perl vendorarch configure option.
Andreas Schneider [Fri, 28 Feb 2014 14:47:45 +0000 (15:47 +0100)]
buildtools: Rename perl vendorarch configure option.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoRevert "pidl: Install pidl files corrently."
Andreas Schneider [Fri, 28 Feb 2014 14:46:01 +0000 (15:46 +0100)]
Revert "pidl: Install pidl files corrently."

This reverts commit cee11cfa4544425099268cd32393169afb4bb107.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoRevert "waf: Add option to specify perl vendor dir."
Andreas Schneider [Fri, 28 Feb 2014 14:45:51 +0000 (15:45 +0100)]
Revert "waf: Add option to specify perl vendor dir."

This reverts commit 9b200555fec2e33da9521db388d1839375aa8d83.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoRevert "pidl: Make perl(Parse:Yapp:Driver) installation optional."
Andreas Schneider [Fri, 28 Feb 2014 14:45:35 +0000 (15:45 +0100)]
Revert "pidl: Make perl(Parse:Yapp:Driver) installation optional."

This reverts commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoctdb-vacuum: fix delete list counts in delete_marshall_traverse_first
Michael Adam [Fri, 21 Feb 2014 22:43:17 +0000 (23:43 +0100)]
ctdb-vacuum: fix delete list counts in delete_marshall_traverse_first

when bumping skipped, decrement left, so the sum is correct

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Mar  6 03:32:33 CET 2014 on sn-devel-104

10 years agoctdb-vacuum: fix possible cause for delelete_list processing counts left records > 0
Michael Adam [Wed, 19 Feb 2014 23:58:17 +0000 (00:58 +0100)]
ctdb-vacuum: fix possible cause for delelete_list processing counts left records > 0

We need to have left records == 0 at the end of the delete list processing.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>