lib/param: clang: Fix 'dereference of a null pointer' warning

Fixes:

lib/param/loadparm.c:3325:36: warning: Access to field 'szService' results in a dereference of a null pointer (loaded from variable 'service') <--[clang]
        return lpcfg_string((const char *)service->szService)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Jun 26 11:53:08 UTC 2019 on sn-devel-184

diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index e03c1556d7e04a487d574342939a0f5ed489e0f9..169d884ec04cdce9191b71387ffe4170d12544c6 100644 (file)
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -3322,7 +3322,7 @@ struct loadparm_service *lpcfg_service(struct loadparm_context *lp_ctx,
 
 const char *lpcfg_servicename(const struct loadparm_service *service)
 {
-       return lpcfg_string((const char *)service->szService);
+       return service ? lpcfg_string((const char *)service->szService) : NULL;
 }
 
 /**