ctdb-daemon: Do not allow database detach if AllowClientDBAttach=1

This avoids the server detaching a database if clients are allowed to
connect to databases.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>

diff --git a/ctdb/server/ctdb_ltdb_server.c b/ctdb/server/ctdb_ltdb_server.c
index 3d8772fc887c8c82845b2b9a133c92a18fda11df..fe8636949d53d7a0cc3e5dd55a65dcdb8872f8f3 100644 (file)
--- a/ctdb/server/ctdb_ltdb_server.c
+++ b/ctdb/server/ctdb_ltdb_server.c
@@ -1182,9 +1182,10 @@ int32_t ctdb_control_db_detach(struct ctdb_context *ctdb, TDB_DATA indata,
                return -1;
        }
 
-       if (ctdb->tunable.allow_client_db_attach == 0) {
-               DEBUG(DEBUG_ERR, ("DB detach from database %s denied by "
-                                 "tunable AllowClientDBAccess == 0\n",
+       if (ctdb->tunable.allow_client_db_attach == 1) {
+               DEBUG(DEBUG_ERR, ("DB detach from database %s denied. "
+                                 "Clients are allowed access to databases "
+                                 "(AllowClientDBAccess == 1)\n",
                                  ctdb_db->db_name));
                return -1;
        }