idmap_rid: remove a legacy comment from sid_to_id
authorMichael Adam <obnox@samba.org>
Fri, 11 Apr 2014 19:03:06 +0000 (21:03 +0200)
committerMichael Adam <obnox@samba.org>
Fri, 25 Apr 2014 13:35:08 +0000 (15:35 +0200)
With the introduction of the ID_TYPE_BOTH mapping
to idmap_rid, it is not a deficiency but a
virtue of the rid backend that it does not
care about the existence or type of the
sid to be mapped.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/winbindd/idmap_rid.c

index 0856c802375136b81452a1a2429f38b94e149487..099f68c5ee31562c9f4756908e2aabde216df9d7 100644 (file)
@@ -87,10 +87,6 @@ static NTSTATUS idmap_rid_id_to_sid(struct idmap_domain *dom, struct id_map *map
 
        sid_compose(map->sid, &domain->sid, map->xid.id - dom->low_id + ctx->base_rid);
 
-       /* We **really** should have some way of validating 
-          the SID exists and is the correct type here.  But 
-          that is a deficiency in the idmap_rid design. */
-
        map->status = ID_MAPPED;
        map->xid.type = ID_TYPE_BOTH;