dsdb-repl_meta_data: Move TODO comment about conflicts and missing parents
authorAndrew Bartlett <abartlet@samba.org>
Thu, 16 May 2013 07:51:56 +0000 (17:51 +1000)
committerStefan Metzmacher <metze@samba.org>
Tue, 28 May 2013 16:11:00 +0000 (18:11 +0200)
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue May 28 18:11:00 CEST 2013 on sn-devel-104

source4/dsdb/samdb/ldb_modules/repl_meta_data.c

index 5fc71ab1d2bced362dd86ca3e10f46a304f7d973..98e60d7a8bf2c9d7e491672fda8232df8dae36c0 100644 (file)
@@ -3658,15 +3658,6 @@ static int replmd_replicated_apply_add(struct replmd_replicated_request *ar)
        int ret;
        bool remote_isDeleted = false;
 
-       /*
-        * TODO: check if the parent object exist
-        */
-
-       /*
-        * TODO: handle the conflict case where an object with the
-        *       same name exist
-        */
-
        ldb = ldb_module_get_ctx(ar->module);
        msg = ar->objs->objects[ar->index_current].msg;
        md = ar->objs->objects[ar->index_current].meta_data;
@@ -3789,6 +3780,10 @@ static int replmd_replicated_apply_search_for_parent_callback(struct ldb_request
        }
        if (ares->error != LDB_SUCCESS &&
            ares->error != LDB_ERR_NO_SUCH_OBJECT) {
+               /*
+                * TODO: deal with the above error that the parent object doesn't exist
+                */
+
                return ldb_module_done(ar->req, ares->controls,
                                        ares->response, ares->error);
        }