s4:repl_meta_data LDB module - rename operation - do not overwrite error messages
authorMatthias Dieter Wallnöfer <mdw@samba.org>
Fri, 14 Oct 2011 07:51:04 +0000 (09:51 +0200)
committerMatthias Dieter Wallnöfer <mdw@samba.org>
Thu, 27 Oct 2011 16:52:29 +0000 (18:52 +0200)
"ldb_error" could overwrite possibly useful error messages.

Reviewed-by: abartlet
source4/dsdb/samdb/ldb_modules/repl_meta_data.c

index d6609733e2cff43025fe381d14172d2a159ae9dc..bffe5a64e00ea6161e5afa1b366893a2d52ddeff 100644 (file)
@@ -2567,9 +2567,7 @@ static int replmd_rename_callback(struct ldb_request *req, struct ldb_reply *are
 
        if (ret != LDB_SUCCESS) {
                talloc_free(ares);
-               return ldb_module_done(ac->req, NULL, NULL,
-                                      ldb_error(ldb, ret,
-                                       "failed to call replmd_update_rpmd()"));
+               return ldb_module_done(ac->req, NULL, NULL, ret);
        }
 
        if (ac->seq_num == 0) {