rpc_server-drsuapi: Include the failing DN when unable to convert DB objects to DRS
authorAndrew Bartlett <abartlet@samba.org>
Tue, 2 Apr 2013 05:10:03 +0000 (16:10 +1100)
committerStefan Metzmacher <metze@samba.org>
Thu, 16 May 2013 17:02:03 +0000 (19:02 +0200)
This is a very serious situation (it should not happen) so getting information on the
objects that this happens for would be very helpful.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
source4/rpc_server/drsuapi/getncchanges.c

index 575d037110112be80055ce648776f6a5cb8a47fa..219ddbc9f37690616839478bcd6a042ddbb7b3d4 100644 (file)
@@ -353,8 +353,9 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                        werr = sa->syntax->ldb_to_drsuapi(&syntax_ctx, sa, el, obj,
                                                          &obj->object.attribute_ctr.attributes[i]);
                        if (!W_ERROR_IS_OK(werr)) {
-                               DEBUG(0,("Unable to convert %s to DRS object - %s\n", 
-                                        sa->lDAPDisplayName, win_errstr(werr)));
+                               DEBUG(0,("Unable to convert %s on %s to DRS object - %s\n",
+                                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn),
+                                        win_errstr(werr)));
                                return werr;
                        }
                        /* if DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING is set
@@ -369,8 +370,9 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                        werr = drsuapi_encrypt_attribute(obj, session_key, rid, 
                                                         &obj->object.attribute_ctr.attributes[i]);
                        if (!W_ERROR_IS_OK(werr)) {
-                               DEBUG(0,("Unable to encrypt %s in DRS object - %s\n", 
-                                        sa->lDAPDisplayName, win_errstr(werr)));
+                               DEBUG(0,("Unable to encrypt %s on %s in DRS object - %s\n",
+                                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn),
+                                        win_errstr(werr)));
                                return werr;
                        }
                }