s3-printing: fix crash in printer_list_set_printer()
authorDavid Disseldorp <ddiss@samba.org>
Wed, 15 Feb 2012 15:30:27 +0000 (16:30 +0100)
committerDavid Disseldorp <ddiss@samba.org>
Wed, 15 Feb 2012 18:34:38 +0000 (19:34 +0100)
The printer list database format was recently changed to accommodate for
the printcap location field.
One of the tdb_pack calls is not provided with a location string
argument, this causes a crash on some platforms.

https://bugzilla.samba.org/show_bug.cgi?id=8762

Signed-off-by: Günther Deschner <gd@samba.org>
Signed-off-by: Jim McDonough <jmcd@samba.org>
Signed-off-by: Lars Müller <lars@samba.org>
Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Wed Feb 15 19:34:38 CET 2012 on sn-devel-104

source3/printing/printer_list.c

index d9e8737660613beaee9293d4b83e8b14676ac357..7079ddc037a9ad7bb31299481718ca0eee5ef2b1 100644 (file)
@@ -191,7 +191,7 @@ NTSTATUS printer_list_set_printer(TALLOC_CTX *mem_ctx,
        data.dsize = len;
 
        len = tdb_pack(data.dptr, data.dsize,
-                      PL_DATA_FORMAT, time_h, time_l, name, str);
+                      PL_DATA_FORMAT, time_h, time_l, name, str, str2);
 
        status = dbwrap_store_bystring_upper(db, key, data, TDB_REPLACE);