s4:kdc/wdc-samba4.c - fix user logins on specific workstations

The decrement operation has been missing.

Problem found by Mohammad Ebrahim Abravi <lamp.mia@gmail.com>

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/kdc/wdc-samba4.c b/source4/kdc/wdc-samba4.c
index 70e849ccb74179b35409f9637806a72c3b4acb7f..2f4945c312ce98dd6c22162748ceff080afd2d04 100644 (file)
--- a/source4/kdc/wdc-samba4.c
+++ b/source4/kdc/wdc-samba4.c
@@ -187,14 +187,15 @@ static char *get_netbios_name(TALLOC_CTX *mem_ctx, HostAddresses *addrs)
                }
        }
 
-       if (nb_name == NULL) {
+       if ((nb_name == NULL) || (nb_name[0] == '\0')) {
                return NULL;
        }
 
        /* Strip space padding */
-       i = strlen(nb_name) - 1;
-       while (i > 0 && nb_name[i] == ' ') {
-               nb_name[i] = '\0';
+       for (len = strlen(nb_name) - 1;
+            (len > 0) && (nb_name[len] == ' ');
+            --len) {
+               nb_name[len] = '\0';
        }
 
        return nb_name;