Andrew Bartlett [Wed, 22 May 2013 02:25:45 +0000 (12:25 +1000)]
build: Remove autoconf directory no longer needed
This was only needed to avoid autoconf and waf builds colliding.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:24:16 +0000 (12:24 +1000)]
build: Remove unused script/mkversion.sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:23:56 +0000 (12:23 +1000)]
build: Remove unused install-sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:23:20 +0000 (12:23 +1000)]
build: Remove autoconf build system
We are now confident that that waf build system meets enough of our needs
that we will work to improve it, rather than maintain two build systems.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 04:23:31 +0000 (14:23 +1000)]
build: No longer run autogen.sh during tarball creation
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 04:35:08 +0000 (14:35 +1000)]
autobuild: Remove samba3 and samba3-ctdb targets to allow autoconf removal for 4.1
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
David Disseldorp [Mon, 27 May 2013 15:57:01 +0000 (17:57 +0200)]
waf: build position independent executables
This patch re-instates support for building Position Independent
Executables using the '-fPIE' and '-pie' compiler and linker flags
respectively.
PIE builds are enabled by default, and can be explicitly disabled using
the '--without-pie' configure argument.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 28 02:56:36 CEST 2013 on sn-devel-104
David Disseldorp [Mon, 27 May 2013 15:57:00 +0000 (17:57 +0200)]
waf: add --with[out]-pie configure arguments
The arguments do not currently have any effect.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Sun, 26 May 2013 11:05:12 +0000 (21:05 +1000)]
build: Install smbtar in waf build
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 27 12:55:05 CEST 2013 on sn-devel-104
Andrew Bartlett [Sun, 26 May 2013 10:29:19 +0000 (20:29 +1000)]
docs: Remove all references to testprns
Based on debian patch documentation2.patch by Christian Perrier <bubulle@debian.org>.
This tool no longer exists in Samba.
Andrew Bartlett
Reviewed-by: Kai Blin <kai@samba.org>
Andrew Bartlett [Wed, 22 May 2013 21:34:15 +0000 (07:34 +1000)]
build: Remove duplicate call to bld.SYMBOL_CHECK()
This was missed when we merged the two waf systems.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 27 10:30:06 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 22 May 2013 23:51:36 +0000 (09:51 +1000)]
build: Remove mkinstalldirs
This is not used in the waf build.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Thu, 23 May 2013 03:17:19 +0000 (13:17 +1000)]
lib/replace: Remove unused install-sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 27 05:51:04 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 22 May 2013 23:51:03 +0000 (09:51 +1000)]
build: Remove unused expand-includes.pl
We no longer have makefiles with includes.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Wed, 22 May 2013 23:38:47 +0000 (09:38 +1000)]
build: Remove old create-tarball release script
Releases are now done via "waf dist" and script/librelease.sh.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Wed, 22 May 2013 23:33:19 +0000 (09:33 +1000)]
build: Do not always regenerate the version.h file
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 21:37:33 +0000 (07:37 +1000)]
smbd: Fix build on platforms that will not support var = {} initialisation
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:13:52 +0000 (00:13 +1000)]
examples: Remove browser and DC settings from example smb.conf
These examples just encourage folks to set browing values that are not needed.
The domain logons setting is already covered by the server role at the
top of the file and logon script is not special enough to be in the
default smb.conf.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:12:23 +0000 (00:12 +1000)]
examples: Remove password server from example smb.conf
This should discourage folks from setting it when they do not really need it.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:11:32 +0000 (00:11 +1000)]
examples: Remove default printing form example smb.conf
These settings are all defaults, and just work for most systems. Users on other platforms
can read man smb.conf, rather than cluttering up this file.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:10:39 +0000 (00:10 +1000)]
examples: Move example smb.conf over to "server role"
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:14:29 +0000 (00:14 +1000)]
build: Rework BSD_STYLE_STATVFS check to match autoconf build
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Sun, 26 May 2013 13:11:03 +0000 (23:11 +1000)]
build: Remove binaries and libraries build groups
Build groups are used in Samba to ensure that even if the dependency
chain for a target is not perfect, that it builds reliably. This
matters most in the early build stages, where we are building the asn1
compiler and autogenerating files.
Once we get to the main stage, dependencies between C files, libraries
and binaries are much clearer, because the C compiler and linker takes
these as inputs anyway.
Groups were added to our waf build for stability during early
development, as dependency information was first imported from the
previous autoconf/perl based build system.
I don't think we need this distinction in the main build of C files
into .o, and when linking these into binaries, because the invocation
of these tools is very well defined, and we will find any missing
inputs very quickly.
As such, I've removed the libraries and binaries targets,
consolidating them with 'main'
By making this change, a build of smbtorture only on a clean tree
drops from 3778 to 2489 targets, and much of the expensive linker
stage is skipped. The time for a null build of smbtorture only also
drops from 4.673s to as low as 2.499s on my laptop.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Sun, 26 May 2013 22:27:44 +0000 (08:27 +1000)]
build: Build all of samba in autoconf make test
The test system actually depends on far more than smbtorture these days
and this was masked by the build groups. Rather than try and specify
everything that could be used, just build the lot (which is what was
essentially being done anyway).
This prepares for the removal of the libraries and binaries build
groups, to assist in improving waf performance for single-binary builds.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Michael Adam [Wed, 24 Apr 2013 13:49:46 +0000 (15:49 +0200)]
s4:idmap: break account_type check lines for readability in idmap_sid_to_xid()
Also makes code obey README.Coding, regarding line-length.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon May 27 00:05:19 CEST 2013 on sn-devel-104
Kai Blin [Sat, 25 May 2013 12:05:22 +0000 (14:05 +0200)]
idl: Add DNS HINFO record support
Not sure if we need this, bug samba.org specifies it, so this can cause ANY queries
against samba.org to fail.
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sun May 26 20:05:38 CEST 2013 on sn-devel-104
Kai Blin [Sat, 25 May 2013 12:05:21 +0000 (14:05 +0200)]
idl: Add DNS RP record support as per RFC 1183
Not sure if we need this, but samba.org specifies it, so this could cause ANY
queries against samba.org to fail.
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Kai Blin [Sat, 25 May 2013 11:21:33 +0000 (13:21 +0200)]
dns: Support larger queries when asking forwarder
This should fix bug #9632
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Kai Blin [Sat, 25 May 2013 11:21:32 +0000 (13:21 +0200)]
idl: Add support for parsing OPT records
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Christof Schmitt [Fri, 24 May 2013 19:40:49 +0000 (12:40 -0700)]
winbind: Print error code on connection error in ping_dc
For debugging, it is useful to include the error code in the message.
Signed-off-by: Christof Schmitt <christof.schmitt@us.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sat May 25 23:11:23 CEST 2013 on sn-devel-104
Vadim Zhukov [Sat, 25 May 2013 14:19:24 +0000 (15:19 +0100)]
pidl: Recent Perl warns about "defined(@var)" constructs.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat May 25 18:10:53 CEST 2013 on sn-devel-104
Anand Avati [Fri, 24 May 2013 19:23:06 +0000 (12:23 -0700)]
building RPMs on RHEL fail because of a typo.
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 25 01:04:37 CEST 2013 on sn-devel-104
Stefan Metzmacher [Fri, 17 May 2013 21:18:55 +0000 (23:18 +0200)]
libnet-vampire: make use of dsdb_repl_resolve_working_schema()
Pair-Programmed-With: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 23 14:18:03 CEST 2013 on sn-devel-104
Stefan Metzmacher [Fri, 17 May 2013 21:18:41 +0000 (23:18 +0200)]
dsdb-repl: merge the logic from libnet_vampire_cb_apply_schema()
This way libnet_vampire_cb_apply_schema() is able to use
dsdb_repl_resolve_working_schema().
Pair-Programmed-With: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Stefan Metzmacher [Fri, 17 May 2013 21:02:03 +0000 (23:02 +0200)]
dsdb-repl: split out dsdb_repl_resolve_working_schema
This can be reused later in other places.
Pair-Programmed-With: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 19 Apr 2013 05:03:23 +0000 (22:03 -0700)]
selftest: Improve test coverage of DRS (bug #8680)
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Sun, 27 Jan 2013 23:43:07 +0000 (15:43 -0800)]
dsdb-drs: when replicating schema object checks ask for removal of previous version if exists (bug #8680)
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Mon, 8 Oct 2012 04:46:38 +0000 (21:46 -0700)]
libnet-vampire: add attributes and classes from the replicated schema to the bootstrap schema (bug #8680)
Replicated schema might have attributes and auxilary classes on some
critical classes (ie. top, user, computer ) that are not in the bootstrap
schema. Without those new attributes and classes, bootstrap schema is
unable to translate those critical classes in the schema constructed
from the replicated data. Without thoses classes new schema is useless
and can't be indexed properly.
In order to overcome this problem, we put all new attributes and classes
definitions into the bootstrap schema so that foundations classes can be
translated.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Sun, 27 Jan 2013 07:42:10 +0000 (23:42 -0800)]
dsdb-schema: make deduplication of class and schema possible (bug #8680)
When a class or an attribute is replicated it might already exists in
the existing schema, so while replicating the new version of this object
we want to get rid of the old version of the object is the current
validating schema so that we don't end up having duplicates.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Stefan Metzmacher [Thu, 23 May 2013 06:46:31 +0000 (08:46 +0200)]
dsdb-schema: schema_fill_possible_inferiors() should rebuild everthing
commit
cd7f3fd07215a7b8372b6b623faed02ae1310cb1 reverted the change
of commit
c2853f55fc603d4875bb1e50a1cbf409df0421ea.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Richard Sharpe [Thu, 23 May 2013 03:05:17 +0000 (20:05 -0700)]
Revert my accidental commit.
Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Thu May 23 06:53:17 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 22 May 2013 07:23:30 +0000 (17:23 +1000)]
lib/replace: Set BROKEN_STRNLEN and BROKEN_STRNDUP on all AIX
The background is in https://bugzilla.samba.org/show_bug.cgi?id=1097
and wider reports are at
http://stackoverflow.com/questions/
2091460/strndup-call-is-currupting-stack-frames
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 23 03:52:10 CEST 2013 on sn-devel-104
Andrew Bartlett [Tue, 21 May 2013 10:44:26 +0000 (20:44 +1000)]
docs: Fix small errors in TOSHARG-Compiling
Reviewed-by: Jeremy Allison <jra@samba.org>
Andrew Bartlett [Tue, 21 May 2013 10:50:30 +0000 (20:50 +1000)]
docs: Remove TOSHARG-HighAvailability which is made obsolete by CTDB
This is mostly a lament on why this is hard, and while CTDB is still
hard, this document tries to imply it is almost impossible, and makes
no mention of the solution.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra@samba.org>
Andrew Bartlett [Tue, 21 May 2013 07:49:55 +0000 (17:49 +1000)]
docs: Remove out of date and unmaintained Speed page from the HOWTO
Reviewed-by: Jeremy Allison <jra@samba.org>
Peng Haitao [Wed, 22 May 2013 21:03:13 +0000 (14:03 -0700)]
When message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPGRADE.
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Peng Haitao [Wed, 22 May 2013 21:02:29 +0000 (14:02 -0700)]
When '--policies-reset' is success, the exit code should be 0.
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:14:19 +0000 (00:14 +1000)]
build: Update md5.h detection in waf and autoconf to use sys/md5.h and -lmd
This brings the two build systems in sync, without using md5.h (which is a problem name)
Tested on FreeBSD
Andrew Bartlett
Reviewed-by: Richard Sharpe <rsharpe@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Wed May 22 10:06:40 CEST 2013 on sn-devel-104
Richard Sharpe [Sat, 11 May 2013 16:47:23 +0000 (09:47 -0700)]
Make sure that if an smbd is exiting because of an error we let the user know.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Günther Deschner [Fri, 17 May 2013 09:23:22 +0000 (11:23 +0200)]
s4-torture: No need to disable rpc.spoolss.win test when compiled with MIT kerberos.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon May 20 20:35:33 CEST 2013 on sn-devel-104
Günther Deschner [Fri, 1 Feb 2013 13:53:12 +0000 (14:53 +0100)]
selftest: mark the spoolss add print processor tests as knownfail for now.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 1 Feb 2013 13:07:50 +0000 (14:07 +0100)]
s4-torture: add simple tests for spoolss_{Add|Delete}PrintProcessor.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 1 Feb 2013 13:07:07 +0000 (14:07 +0100)]
doserr: add mapping for WERR_PRINT_PROCESSOR_ALREADY_INSTALLED.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 1 Feb 2013 01:34:11 +0000 (02:34 +0100)]
spoolss: fill in IDL for spoolss_DeletePrintProcessor.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 31 Jan 2013 21:06:20 +0000 (22:06 +0100)]
s4-torture: also deal with "Microsoft XPS Document Writer v4" as default driver.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 31 Jan 2013 13:56:17 +0000 (14:56 +0100)]
s4-torture: add ndr test for spoolss_RpcSetJobNamedProperty.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Tue, 22 Jan 2013 09:17:27 +0000 (10:17 +0100)]
s4-torture: add ndr test for spoolss_GetCorePrinterDrivers.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 31 Jan 2013 19:44:54 +0000 (20:44 +0100)]
s4-torture: add simple test for spoolss_RpcSendRecvBidiData.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Mon, 21 Jan 2013 21:09:22 +0000 (22:09 +0100)]
s4-torture: add test for spoolss_RpcEnumJobNamedProperties.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Sun, 24 Feb 2013 13:06:59 +0000 (14:06 +0100)]
spoolss: add spoolss_MonitorContainer IDL.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 24 Jan 2013 22:31:19 +0000 (23:31 +0100)]
spoolss: make RPC_PrintNamedProperty public
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Mon, 21 Jan 2013 20:37:12 +0000 (21:37 +0100)]
spoolss: fill in IDL for JobNamedProperty calls.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 18 Jan 2013 23:20:42 +0000 (00:20 +0100)]
spoolss: make more container objects public for iremotewinspool.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 18 Jan 2013 23:47:42 +0000 (00:47 +0100)]
spoolss: add idl for spoolss_RpcSendRecvBidiData.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Tue, 5 Feb 2013 15:10:34 +0000 (16:10 +0100)]
s4-torture: add missing NTSTATUS checks in test_AddJob().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Wed, 30 Jan 2013 19:05:51 +0000 (20:05 +0100)]
spoolss: add [ms_union] to spoolss.idl where appropriate.
Normally we would activate [ms_union] for the entire interface but given the
fact we use this IDL file also for custom-marshalled structures we would
generate union arm alignment also for the custom-marshalled unions where they
are inappropriate. Thus, only enable [ms_union] only for unions that are part of
the MS-RPRN IDL.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Wed, 30 Jan 2013 14:55:18 +0000 (15:55 +0100)]
spoolss: fix string types in spoolss_JTEXP.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Tue, 29 Jan 2013 20:57:58 +0000 (21:57 +0100)]
spoolss: Fix two size elements in the devmode private spoolss_JTEXP struct.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Volker Lendecke [Mon, 20 May 2013 12:26:08 +0000 (14:26 +0200)]
talloc: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Mon May 20 18:48:49 CEST 2013 on sn-devel-104
Matthieu Patou [Wed, 2 Jan 2013 04:57:25 +0000 (20:57 -0800)]
ldb_tdb: Warn when reindexing is done
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 20 15:47:33 CEST 2013 on sn-devel-104
Matthieu Patou [Fri, 17 May 2013 15:14:29 +0000 (17:14 +0200)]
smbtorture: Show the list of cracknames we expect to have and the result
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 14:21:57 +0000 (07:21 -0700)]
smbtorture: fix a warning due to a set but unused var
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 14:19:22 +0000 (07:19 -0700)]
smbtorture: fix crash when the returning a crackname with an empty name
when a valid one was expected
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:26:46 +0000 (05:26 -0700)]
Fix warning by setting the variable from GUID to const GUID
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:24:08 +0000 (05:24 -0700)]
Fix more unused vars
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:22:33 +0000 (05:22 -0700)]
Fix a warning about a set but unused variable by actually using it
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:22:15 +0000 (05:22 -0700)]
Fix warnings about set but unused variables
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 12:17:41 +0000 (05:17 -0700)]
Fix a warning about a shadowed variable by renaming the shadowing var
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 17 May 2013 11:50:20 +0000 (04:50 -0700)]
buildtools: Fix compilation warnings
STATIC_%s_MODULES_PROTO is defined on the compilation command line by
-DSTATIC_<something>_MODULES_PROTO which the compiler seems to turn into
define STATIC_<something>_MODULES_PROTO 1 thus yielding a warning due to
unused var
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Tue, 22 Jan 2013 08:09:11 +0000 (00:09 -0800)]
operational: remove double loops
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Tue, 22 Jan 2013 06:27:10 +0000 (22:27 -0800)]
dsdb-schema: remove looping on all schema classes for system_possible_inferrior
The logic to populate possible inferriors and system possible inferriors
is the same so instead of looping twice we do both attributes (depending
on the type of the class) in the same loop
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Kai Blin [Fri, 17 May 2013 12:16:26 +0000 (14:16 +0200)]
swat: Remove swat.
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat May 18 16:32:38 CEST 2013 on sn-devel-104
Kai Blin [Fri, 18 Jan 2013 17:36:45 +0000 (18:36 +0100)]
dns: Also print packet information for DBGC_DNS
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat May 18 12:48:15 CEST 2013 on sn-devel-104
Kai Blin [Fri, 18 Jan 2013 17:35:15 +0000 (18:35 +0100)]
librpc: Add NDR_PRINT_DEBUGC to ndr print to a debug class
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Kai Blin [Fri, 18 Jan 2013 08:44:02 +0000 (09:44 +0100)]
debug: Add ability to dump_data per debug class
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Volker Lendecke [Fri, 17 May 2013 13:14:58 +0000 (15:14 +0200)]
smbd: Fix a ISO C90 forbids mixed declarations and code warning
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Sat May 18 01:40:04 CEST 2013 on sn-devel-104
Vadim Zhukov [Fri, 17 May 2013 08:43:08 +0000 (12:43 +0400)]
More generic check for OpenBSD platform
OpenBSD versioning is different from many other
projects, and, say, 5.0 does not differ from 4.9 more than from 5.1. So the
right approach will be to check that platform name starts with "openbsd"
instead. This is also the thing OpenBSD developers do when patching other
software, so this patch is consistent with already existing practicies.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9888
Reviewed-by: Lars Müller <lars@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri May 17 17:58:16 CEST 2013 on sn-devel-104
Björn Jacke [Wed, 15 May 2013 13:52:25 +0000 (15:52 +0200)]
docs: mention AD prerequirements for using idmap_ad
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Björn Jacke [Wed, 15 May 2013 11:34:33 +0000 (13:34 +0200)]
doc: some fixes for vfs_full_audit man page
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Matthias Dieter Wallnöfer [Fri, 17 May 2013 08:31:28 +0000 (10:31 +0200)]
s4:dsdb python tests - set the executable flag
Reviewed-by: Matthieu Patou <mat@samba.org>
Autobuild-User(master): Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date(master): Fri May 17 15:11:29 CEST 2013 on sn-devel-104
Christian Ambach [Thu, 16 May 2013 13:07:44 +0000 (15:07 +0200)]
s3:lib/ctdb_conn make sure we are root before connecting to CTDB
CTDB socket is only reachable for root, make sure we are root when trying to connect to it
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Fri May 17 13:16:37 CEST 2013 on sn-devel-104
Volker Lendecke [Thu, 16 May 2013 14:11:54 +0000 (16:11 +0200)]
lib: Add before/after hooks to async_connect
This will facilitiate [un]become_root for smbd to connect safely to ctdbd.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
Christian Ambach [Tue, 7 May 2013 07:08:07 +0000 (09:08 +0200)]
waf: build vfs_aixacl2 module by default on AIX
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Tue, 7 May 2013 07:06:50 +0000 (09:06 +0200)]
waf: only use -fstack-protector when both compiler and linker support it
otherwise build with xlc on AIX fails because the compiler silently ignores the parameter
but the linker does not like it
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Björn Jacke [Thu, 16 May 2013 14:19:22 +0000 (16:19 +0200)]
docs/rpcdaemon: some formating fixes
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 17 10:34:18 CEST 2013 on sn-devel-104
Matthieu Patou [Sat, 12 Jan 2013 04:05:39 +0000 (20:05 -0800)]
drsuapi: Debug more clearly why NC is bad in updateRefs
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 17 04:17:14 CEST 2013 on sn-devel-104
Christian Ambach [Thu, 16 May 2013 13:06:49 +0000 (15:06 +0200)]
nsswitch: fix some typos
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 17 01:09:33 CEST 2013 on sn-devel-104
Christian Ambach [Tue, 14 May 2013 19:02:15 +0000 (21:02 +0200)]
s3:lib/dbwrap add missing curly braces
violation of README.Coding
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Christian Ambach [Tue, 23 Apr 2013 09:20:42 +0000 (11:20 +0200)]
s3:include remove non-blank line endings
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Thu, 16 May 2013 00:32:50 +0000 (10:32 +1000)]
auth: Ensure auth_sam is not used on the AD DC
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu May 16 22:51:26 CEST 2013 on sn-devel-104
git.samba.org / obnox / samba / samba-obnox.git / log