ldb:ldb_dn: use safe NUMERIC_CMP in ldb_dn_compare_base()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c
index 39fe1e81f0dd82dbb2a2363f0a020c10b5da7281..95a903244c69cdcd4850f69e02bce0f4e4f67e2a 100644 (file)
--- a/lib/ldb/common/ldb_dn.c
+++ b/lib/ldb/common/ldb_dn.c
@@ -1111,7 +1111,7 @@ int ldb_dn_compare_base(struct ldb_dn *base, struct ldb_dn *dn)
 
                /* compare attr.cf_value. */
                if (b_vlen != dn_vlen) {
-                       return b_vlen - dn_vlen;
+                       return NUMERIC_CMP(b_vlen, dn_vlen);
                }
                ret = strncmp(b_vdata, dn_vdata, b_vlen);
                if (ret != 0) return ret;