rpc_server: Fix CID 1063255 Resource leak
authorVolker Lendecke <vl@samba.org>
Sun, 18 Aug 2013 20:41:51 +0000 (20:41 +0000)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 19 Aug 2013 01:10:51 +0000 (03:10 +0200)
We would leak a socket 0 here

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Aug 19 03:10:51 CEST 2013 on sn-devel-104

source3/rpc_server/rpc_server.c

index de54ddc6e28e7fe7bf42e80e1efacc97f7be34b2..fa3c8709fa397738f6a01e2508a5c9c935417592 100644 (file)
@@ -620,7 +620,7 @@ int create_tcpip_socket(const struct sockaddr_storage *ifss, uint16_t *port)
                                            0,
                                            ifss,
                                            false);
-                       if (fd > 0) {
+                       if (fd >= 0) {
                                *port = i;
                                break;
                        }