Fix a few "might be uninitialized" errors
authorVolker Lendecke <vl@samba.org>
Mon, 22 Jan 2024 20:33:05 +0000 (21:33 +0100)
committerJeremy Allison <jra@samba.org>
Tue, 23 Apr 2024 19:02:10 +0000 (19:02 +0000)
I've seen them with clang

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Apr 23 19:02:10 UTC 2024 on atb-devel-224

source3/libsmb/libsmb_file.c
source4/auth/sam.c
source4/dsdb/common/rodc_helper.c

index ff18d5697577e9f1a31956553655529bc3475755..5861718d67221f717cbd11b5537566d11d68ddc5 100644 (file)
@@ -470,7 +470,7 @@ SMBC_getatr(SMBCCTX * context,
        mode_t mode = S_IFREG;
        struct cli_credentials *creds = NULL;
        TALLOC_CTX *frame = talloc_stackframe();
-       NTSTATUS status;
+       NTSTATUS status = NT_STATUS_ACCESS_DENIED;
 
        if (!context || !context->internal->initialized) {
                TALLOC_FREE(frame);
index 1445adf226121c37908d5d70f532a8d4a137a79c..bd8219d733525d42b49e1740f4b0e528023486d1 100644 (file)
@@ -1581,7 +1581,7 @@ NTSTATUS authsam_logon_success_accounting(struct ldb_context *sam_ctx,
        NTTIME sync_interval_nt = 0;
        bool am_rodc = false;
        bool txn_active = false;
-       bool need_db_reread;
+       bool need_db_reread = false;
 
        mem_ctx = talloc_new(msg);
        if (mem_ctx == NULL) {
index b4982aee9ed45f056594375a8afc7e33d96cf4df..5ed60e0af438f9066822ff4e0fcc8e097bb1d627 100644 (file)
@@ -243,7 +243,7 @@ WERROR samdb_confirm_rodc_allowed_to_repl_to(struct ldb_context *sam_ctx,
 {
        TALLOC_CTX *frame = talloc_stackframe();
        WERROR werr;
-       uint32_t num_token_sids;
+       uint32_t num_token_sids = 0;
        struct dom_sid *token_sids;
        const struct dom_sid *object_sid = NULL;